Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8069)

Unified Diff: chrome/browser/chromeos/settings/cros_settings.cc

Issue 14927015: Translate device-local account IDs to user IDs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix forward declaration. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/cros_settings.cc
diff --git a/chrome/browser/chromeos/settings/cros_settings.cc b/chrome/browser/chromeos/settings/cros_settings.cc
index 050bef9cfb1bcfa58d8fc0f85b6e4525618b5f58..799d925b1f68302a96b5169f41ed633149e73151 100644
--- a/chrome/browser/chromeos/settings/cros_settings.cc
+++ b/chrome/browser/chromeos/settings/cros_settings.cc
@@ -28,7 +28,7 @@ static CrosSettings* g_cros_settings = NULL;
// static
void CrosSettings::Initialize() {
CHECK(!g_cros_settings);
- g_cros_settings = new CrosSettings();
+ g_cros_settings = new CrosSettings(DeviceSettingsService::Get());
}
// static
@@ -49,6 +49,27 @@ CrosSettings* CrosSettings::Get() {
return g_cros_settings;
}
+CrosSettings::CrosSettings(DeviceSettingsService* device_settings_service) {
+ CrosSettingsProvider::NotifyObserversCallback notify_cb(
+ base::Bind(&CrosSettings::FireObservers,
+ // This is safe since |this| is never deleted.
+ base::Unretained(this)));
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kStubCrosSettings)) {
+ AddSettingsProvider(new StubCrosSettingsProvider(notify_cb));
+ } else {
+ AddSettingsProvider(
+ new DeviceSettingsProvider(notify_cb, device_settings_service));
+ }
+ // System settings are not mocked currently.
+ AddSettingsProvider(new SystemSettingsProvider(notify_cb));
+}
+
+CrosSettings::~CrosSettings() {
+ STLDeleteElements(&providers_);
+ STLDeleteValues(&settings_observers_);
+}
+
bool CrosSettings::IsCrosSettings(const std::string& path) {
return StartsWithASCII(path, kCrosSettingsPrefix, true);
}
@@ -298,27 +319,6 @@ CrosSettingsProvider* CrosSettings::GetProvider(
return NULL;
}
-CrosSettings::CrosSettings() {
- CrosSettingsProvider::NotifyObserversCallback notify_cb(
- base::Bind(&CrosSettings::FireObservers,
- // This is safe since |this| is never deleted.
- base::Unretained(this)));
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kStubCrosSettings)) {
- AddSettingsProvider(new StubCrosSettingsProvider(notify_cb));
- } else {
- AddSettingsProvider(
- new DeviceSettingsProvider(notify_cb, DeviceSettingsService::Get()));
- }
- // System settings are not mocked currently.
- AddSettingsProvider(new SystemSettingsProvider(notify_cb));
-}
-
-CrosSettings::~CrosSettings() {
- STLDeleteElements(&providers_);
- STLDeleteValues(&settings_observers_);
-}
-
void CrosSettings::FireObservers(const std::string& path) {
DCHECK(CalledOnValidThread());
SettingsObserverMap::iterator observer_iterator =
« no previous file with comments | « chrome/browser/chromeos/settings/cros_settings.h ('k') | chrome/browser/chromeos/settings/cros_settings_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698