Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4026)

Unified Diff: chrome/browser/chromeos/settings/cros_settings.h

Issue 14927015: Translate device-local account IDs to user IDs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed. Kiosk apps fixed. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/cros_settings.h
diff --git a/chrome/browser/chromeos/settings/cros_settings.h b/chrome/browser/chromeos/settings/cros_settings.h
index 8a312aa54403ae1756817472d1ea0b77d21ed695..2acfd3a95247272474b92ffbbac8c044254a9689 100644
--- a/chrome/browser/chromeos/settings/cros_settings.h
+++ b/chrome/browser/chromeos/settings/cros_settings.h
@@ -24,6 +24,8 @@ class Value;
namespace chromeos {
+class DeviceSettingsService;
+
// This class manages per-device/global settings.
class CrosSettings : public base::NonThreadSafe {
public:
@@ -33,6 +35,11 @@ class CrosSettings : public base::NonThreadSafe {
static void Shutdown();
static CrosSettings* Get();
+ // Creates a device settings service instance. This is meant for unit tests,
+ // production code uses the singleton returned by Get() above.
+ CrosSettings(DeviceSettingsService* device_settings_service);
+ virtual ~CrosSettings();
+
// Helper function to test if the given |path| is a valid cros setting.
static bool IsCrosSettings(const std::string& path);
@@ -99,9 +106,6 @@ class CrosSettings : public base::NonThreadSafe {
private:
friend class CrosSettingsTest;
- CrosSettings();
- virtual ~CrosSettings();
-
// Fires system setting change notification.
void FireObservers(const std::string& path);

Powered by Google App Engine
This is Rietveld 408576698