Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2044)

Unified Diff: appengine/gaetesting/middleware.go

Issue 1492273003: Remove gaelogger from luci-go (Closed) Base URL: https://github.com/luci/luci-go@master
Patch Set: rm memlogger Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/gaemiddleware/context.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/gaetesting/middleware.go
diff --git a/appengine/gaetesting/middleware.go b/appengine/gaetesting/middleware.go
index 6fdfd1e6fc90224979a7d62ef2c58890ca1039ee..23796124622f16753cf1c587fc688b822d36ca99 100644
--- a/appengine/gaetesting/middleware.go
+++ b/appengine/gaetesting/middleware.go
@@ -9,7 +9,6 @@ import (
"github.com/julienschmidt/httprouter"
"github.com/luci/gae/impl/memory"
- "github.com/luci/luci-go/common/logging/memlogger"
"github.com/luci/luci-go/server/middleware"
"github.com/luci/luci-go/server/secrets/testsecrets"
"golang.org/x/net/context"
@@ -18,7 +17,6 @@ import (
// BaseTest adapts a middleware-style handler to a httprouter.Handle. It passes
// a new context to `h` with the following services installed:
// * github.com/luci/gae/impl/memory (in-memory appengine services)
-// * github.com/luci/luci-go/common/logging/memlogger (in-memory logging service)
// * github.com/luci/luci-go/server/secrets/testsecrets (access to fake secret keys)
func BaseTest(h middleware.Handler) httprouter.Handle {
return func(rw http.ResponseWriter, r *http.Request, p httprouter.Params) {
@@ -30,7 +28,6 @@ func BaseTest(h middleware.Handler) httprouter.Handle {
func TestingContext() context.Context {
c := context.Background()
c = memory.Use(c)
- c = memlogger.Use(c)
c = testsecrets.Use(c)
return c
}
« no previous file with comments | « appengine/gaemiddleware/context.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698