Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 14918010: Make inspector objects ScriptWrappable (Closed)

Created:
7 years, 7 months ago by Tom Sepez
Modified:
7 years, 7 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M Source/core/inspector/InjectedScriptHost.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptHost.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/ScriptProfile.h View 3 chunks +5 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptProfileNode.h View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Sepez
Adam, please review.
7 years, 7 months ago (2013-05-17 17:08:00 UTC) #1
abarth-chromium
+pfeldman It would probably be better if some inspector folks reviewed this CL. For context, ...
7 years, 7 months ago (2013-05-17 18:56:17 UTC) #2
yurys
lgtm
7 years, 7 months ago (2013-05-17 22:38:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/14918010/1
7 years, 7 months ago (2013-05-20 17:13:12 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=5685
7 years, 7 months ago (2013-05-20 19:35:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/14918010/1
7 years, 7 months ago (2013-05-20 20:38:27 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 21:08:33 UTC) #7
Message was sent while issue was closed.
Change committed as 150692

Powered by Google App Engine
This is Rietveld 408576698