Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 14917019: Refactoring CSS grammar (Closed)

Created:
7 years, 7 months ago by SeRya
Modified:
7 years, 7 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, darktears, Eric Willigers, rune
Visibility:
Public.

Description

Refactoring CSS grammar Nonfunctional change. Introduced closing_parenthesis and error_recovery to reduce code duplication. Extracted from https://codereview.chromium.org/14969002/ BUG=140608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149948

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M Source/core/css/CSSGrammar.y.in View 1 9 chunks +22 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
SeRya
7 years, 7 months ago (2013-05-07 15:32:48 UTC) #1
SeRya
7 years, 7 months ago (2013-05-07 20:10:00 UTC) #2
Eric Willigers
lgtm
7 years, 7 months ago (2013-05-08 04:48:25 UTC) #3
apavlov
A ; added, and we are good to land https://codereview.chromium.org/14917019/diff/1/Source/core/css/CSSGrammar.y.in File Source/core/css/CSSGrammar.y.in (right): https://codereview.chromium.org/14917019/diff/1/Source/core/css/CSSGrammar.y.in#newcode1961 Source/core/css/CSSGrammar.y.in:1961: ...
7 years, 7 months ago (2013-05-08 07:03:32 UTC) #4
SeRya
https://codereview.chromium.org/14917019/diff/1/Source/core/css/CSSGrammar.y.in File Source/core/css/CSSGrammar.y.in (right): https://codereview.chromium.org/14917019/diff/1/Source/core/css/CSSGrammar.y.in#newcode1961 Source/core/css/CSSGrammar.y.in:1961: On 2013/05/08 07:03:33, apavlov wrote: > ; Done.
7 years, 7 months ago (2013-05-08 09:03:53 UTC) #5
apavlov
lgtm
7 years, 7 months ago (2013-05-08 09:18:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/14917019/8001
7 years, 7 months ago (2013-05-08 09:18:57 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 09:58:04 UTC) #8
Message was sent while issue was closed.
Change committed as 149948

Powered by Google App Engine
This is Rietveld 408576698