Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 14910010: Do not use $ANDROID_TOOLCHAIN set by envsetup.sh. (Closed)

Created:
7 years, 7 months ago by digit1
Modified:
7 years, 7 months ago
Reviewers:
navabi1, Yaron, Xianzhu
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Do not use $ANDROID_TOOLCHAIN set by envsetup.sh. This reverts the changes from commit 6394facfcd6150a69be418212f1caff2f6639540 and instead improves the adb_gdb script to properly auto-detect the right location of the toolchain binaries. This means that on a Linux 64-bit systems, it will first try to find the 64-bit binaries, and if not available, will fallback to 32-bit ones. Tested with the default toolchain from third_party/android_tools/ndk/ (64-bit) and with --ndk-dir=/path/to/android-ndk-r8d (32-bit). Also remove "gdb_apk" and "gdb_content_shell" which were obsoleted by "adb_gdb" and "adb_gdb_content_shell", respectively. BUG=none R=yfriedman@chromium.org,navabi@chromium.org,wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -187 lines) Patch
M build/android/adb_gdb View 3 chunks +79 lines, -0 lines 0 comments Download
D build/android/gdb_apk View 1 chunk +0 lines, -171 lines 0 comments Download
D build/android/gdb_content_shell View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
digit1
7 years, 7 months ago (2013-05-13 13:42:45 UTC) #1
Xianzhu
Will $ANDROID_TOOLCHAIN set by envsetup.sh be incorrect? If yes, why don't we fix envsetup.sh?
7 years, 7 months ago (2013-05-13 16:05:10 UTC) #2
Xianzhu
On 2013/05/13 16:05:10, Xianzhu wrote: > Will $ANDROID_TOOLCHAIN set by envsetup.sh be incorrect? If yes, ...
7 years, 7 months ago (2013-05-13 16:07:36 UTC) #3
Xianzhu
lgtm
7 years, 7 months ago (2013-05-13 16:08:37 UTC) #4
Yaron
lgtm
7 years, 7 months ago (2013-05-13 16:15:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/14910010/1
7 years, 7 months ago (2013-05-13 16:17:07 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=127032
7 years, 7 months ago (2013-05-13 17:05:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/14910010/1
7 years, 7 months ago (2013-05-16 13:34:39 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 16:19:42 UTC) #9
Message was sent while issue was closed.
Change committed as 200547

Powered by Google App Engine
This is Rietveld 408576698