Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 14910007: Fix breaking change from next SDK (Closed)

Created:
7 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Fix breaking change from next SDK R=dgrove@google.com Committed: https://github.com/dart-lang/web-ui/commit/f5dd0e3

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M bin/dwc_browser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/analyzer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/paths.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/14910007/diff/1/pubspec.yaml File pubspec.yaml (right): https://chromiumcodereview.appspot.com/14910007/diff/1/pubspec.yaml#newcode5 pubspec.yaml:5: version: 0.4.7 i was thinking we can jump to ...
7 years, 7 months ago (2013-05-03 18:24:03 UTC) #1
dgrove
lgtm
7 years, 7 months ago (2013-05-03 18:34:17 UTC) #2
Siggi Cherem (dart-lang)
7 years, 7 months ago (2013-05-03 18:34:59 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rf5dd0e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698