Load and send Wallet Risk params after user has agreed

chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/guid.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/prefs/pref_service.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_view.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/autofill/browser/autofill_common_test.h"
 #include "components/autofill/browser/autofill_metrics.h"
+#include "components/autofill/browser/risk/proto/fingerprint.pb.h"
 #include "components/autofill/browser/test_personal_data_manager.h"
 #include "components/autofill/browser/wallet/full_wallet.h"
 #include "components/autofill/browser/wallet/instrument.h"
 #include "components/autofill/browser/wallet/wallet_address.h"
 #include "components/autofill/browser/wallet/wallet_client.h"
 #include "components/autofill/browser/wallet/wallet_test_util.h"
 #include "components/autofill/common/form_data.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/test_browser_thread.h"
 #include "content/public/test/web_contents_tester.h"
@@ skipping 146 matching lines @@
   }
 
   TestPersonalDataManager* GetTestingManager() {
     return &test_manager_;
   }
 
   TestWalletClient* GetTestingWalletClient() {
     return &test_wallet_client_;
   }
 
+  MOCK_METHOD0(LoadRiskFingerprintData, void());
+
   void set_is_first_run(bool is_first_run) { is_first_run_ = is_first_run; }
+  void set_fingerprint_data(std::string fingerprint_data) {

[Ilya Sherman, 2013/05/03 07:38:31]

nit: Pass by const-reference.

[Dan Beam, 2013/05/03 23:02:40]

Done.

+    fingerprint_data_ = fingerprint_data;
+  }
 
  protected:
   virtual PersonalDataManager* GetManager() OVERRIDE {
     return &test_manager_;
   }
 
   virtual wallet::WalletClient* GetWalletClient() OVERRIDE {
     return &test_wallet_client_;
   }
 
   virtual bool IsFirstRun() const OVERRIDE {
     return is_first_run_;
   }
 
+  virtual void SerializeFingerprint(risk::Fingerprint* fingerprint,
+                                    std::string* data) {
+    // Ignore |fingerprint|, it's NULL.

[Ilya Sherman, 2013/05/03 07:38:31]

Why?  It seems much better not to override this method at all, and just test for
an actual serialized protocol buffer in the test.

[Dan Beam, 2013/05/03 09:24:47]

If it's obvious what the base64 encoded expected text would be, that's fine by
me.

[Ilya Sherman, 2013/05/07 00:59:30]

It's pretty easy to encode the data and DLOG what the encoding is, then set that
as the test's expectation.

[Dan Beam, 2013/05/07 05:02:38]

Done.

+    data->assign(fingerprint_data_);
+  }
+
  private:
   // To specify our own metric logger.
   virtual const AutofillMetrics& GetMetricLogger() const OVERRIDE {
     return metric_logger_;
   }
 
   const AutofillMetrics& metric_logger_;
   TestPersonalDataManager test_manager_;
   testing::NiceMock<TestWalletClient> test_wallet_client_;
   bool is_first_run_;
+  std::string fingerprint_data_;
 
   DISALLOW_COPY_AND_ASSIGN(TestAutofillDialogController);
 };
 
 class AutofillDialogControllerTest : public testing::Test {
  public:
   AutofillDialogControllerTest()
     : ui_thread_(BrowserThread::UI, &loop_),
       file_thread_(BrowserThread::FILE),
       file_blocking_thread_(BrowserThread::FILE_USER_BLOCKING),
@@ skipping 14 matching lines @@
       form_data.fields.push_back(field);
     }
 
     profile()->CreateRequestContext();
     test_web_contents_.reset(
         content::WebContentsTester::CreateTestWebContents(profile(), NULL));
 
     base::Callback<void(const FormStructure*, const std::string&)> callback =
         base::Bind(&AutofillDialogControllerTest::FinishedCallback,
                    base::Unretained(this));
-    controller_ = (new TestAutofillDialogController(
+    controller_ = (new testing::NiceMock<TestAutofillDialogController>(
         test_web_contents_.get(),
         form_data,
         GURL(),
         metric_logger_,
         DIALOG_TYPE_REQUEST_AUTOCOMPLETE,
         callback))->AsWeakPtr();
     controller_->Init(profile());
     controller_->Show();
     controller_->OnUserNameFetchSuccess(kFakeEmail);
   }
@@ skipping 683 matching lines @@
   controller()->EditCancelledForSection(SECTION_EMAIL);
   EXPECT_FALSE(controller()->ShouldOfferToSaveInChrome());
 
   controller()->MenuModelForSection(SECTION_EMAIL)->ActivatedAt(1);
   EXPECT_TRUE(controller()->ShouldOfferToSaveInChrome());
 
   profile()->set_incognito(true);
   EXPECT_FALSE(controller()->ShouldOfferToSaveInChrome());
 }
 
+TEST_F(AutofillDialogControllerTest, RiskRespectsLegalDocs) {
+  EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(0);
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddLegalDocument(wallet::GetTestLegalDocument());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+
+  EXPECT_EQ("risky business", controller()->GetRiskData());
+}
+
+TEST_F(AutofillDialogControllerTest, LoadRiskWhenNoLegalDocs) {
+  EXPECT_CALL(*controller(), LoadRiskFingerprintData()).Times(1);
+
+  scoped_ptr<wallet::WalletItems> wallet_items = wallet::GetTestWalletItems();
+  wallet_items->AddLegalDocument(wallet::GetTestLegalDocument());
+  controller()->OnDidGetWalletItems(wallet_items.Pass());
+  controller()->OnDidAcceptLegalDocuments();
+
+  // No OnRiskFingerprintDataLoaded() has happened yet.
+  EXPECT_EQ("risky business", controller()->GetRiskData());
+
+  scoped_ptr<risk::Fingerprint> fake_fingerprint;
+
+  controller()->set_fingerprint_data("hello");
+  controller()->OnDidLoadRiskFingerprintData(fake_fingerprint.Pass());
+  EXPECT_EQ("aGVsbG8=", controller()->GetRiskData());
+}
+
 }  // namespace autofill