content/renderer/media/renderer_gpu_video_accelerator_factories.h - Issue 1490333005: Don't require VDAs to return all PictureBuffers at once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/renderer_gpu_video_accelerator_factories.h

Issue 1490333005: Don't require VDAs to return all PictureBuffers at once. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ...because trybots have feelings too. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/media/gpu_video_accelerator_util.cc ('K') | « content/gpu/gpu_main.cc ('k') | content/renderer/media/renderer_gpu_video_accelerator_factories.cc » ('j') | media/filters/gpu_video_decoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/renderer_gpu_video_accelerator_factories.h

diff --git a/content/renderer/media/renderer_gpu_video_accelerator_factories.h b/content/renderer/media/renderer_gpu_video_accelerator_factories.h

index dea8c201a11a19049b03e2b8464943cb52a17b50..5f68546ca2f0220f424e1bac8959a6c3acdde8cb 100644

--- a/content/renderer/media/renderer_gpu_video_accelerator_factories.h

+++ b/content/renderer/media/renderer_gpu_video_accelerator_factories.h

@@ -81,8 +81,8 @@ class CONTENT_EXPORT RendererGpuVideoAcceleratorFactories

scoped_ptr<base::SharedMemory> CreateSharedMemory(size_t size) override;

scoped_refptr<base::SingleThreadTaskRunner> GetTaskRunner() override;

- std::vector<media::VideoDecodeAccelerator::SupportedProfile>

- GetVideoDecodeAcceleratorSupportedProfiles() override;

+ media::VideoDecodeAccelerator::Capabilities

+ GetVideoDecodeAcceleratorCapabilities() override;

Pawel Osciak 2015/12/05 00:18:55 Please indent.

liberato (no reviews please) 2015/12/07 19:04:39 unfortunately, 'git cl format' will just un-indent

Pawel Osciak 2015/12/09 01:31:48 Hm, strange, GetVideoEncodeAcceleratorSupportedPro

std::vector<media::VideoEncodeAccelerator::SupportedProfile>

GetVideoEncodeAcceleratorSupportedProfiles() override;