Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Unified Diff: media/filters/gpu_video_decoder.h

Issue 1490333005: Don't require VDAs to return all PictureBuffers at once. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cl feedback. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_info_unittest.cc ('k') | media/filters/gpu_video_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/gpu_video_decoder.h
diff --git a/media/filters/gpu_video_decoder.h b/media/filters/gpu_video_decoder.h
index 065ac38d068abecdea8bdc5b769fd6fbec54f915..81c7d6c65046e44b76e4b97b999ebe4281402751 100644
--- a/media/filters/gpu_video_decoder.h
+++ b/media/filters/gpu_video_decoder.h
@@ -135,9 +135,12 @@ class MEDIA_EXPORT GpuVideoDecoder
// Destroy all PictureBuffers in |buffers|, and delete their textures.
void DestroyPictureBuffers(PictureBufferMap* buffers);
- // Returns true if the video decoder can support |profile| and |coded_size|.
- bool IsProfileSupported(VideoCodecProfile profile,
- const gfx::Size& coded_size);
+ // Returns true if the video decoder with |capabilities| can support
+ // |profile| and |coded_size|.
+ bool IsProfileSupported(
+ const VideoDecodeAccelerator::Capabilities& capabilities,
+ VideoCodecProfile profile,
+ const gfx::Size& coded_size);
// Assert the contract that this class is operated on the right thread.
void DCheckGpuVideoAcceleratorFactoriesTaskRunnerIsCurrent() const;
@@ -203,6 +206,12 @@ class MEDIA_EXPORT GpuVideoDecoder
// HasAvailableOutputFrames().
int available_pictures_;
+ // If true, the client cannot expect the VDA to produce any new decoded
+ // frames, until it returns all PictureBuffers it may be holding back to the
+ // VDA. In other words, the VDA may require all PictureBuffers to be able to
+ // proceed with decoding the next frame.
+ bool needs_all_picture_buffers_to_decode_;
+
// Bound to factories_->GetMessageLoop().
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<GpuVideoDecoder> weak_factory_;
« no previous file with comments | « gpu/config/gpu_info_unittest.cc ('k') | media/filters/gpu_video_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698