Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: content/common/gpu/media/android_copying_backing_strategy.cc

Issue 1490333005: Don't require VDAs to return all PictureBuffers at once. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cl feedback. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/android_copying_backing_strategy.cc
diff --git a/content/common/gpu/media/android_copying_backing_strategy.cc b/content/common/gpu/media/android_copying_backing_strategy.cc
index 912ba4534f331e1eba97954ea9674c45f7283769..30e4bc1aa20798bd78fcc59c9a77a343a063151f 100644
--- a/content/common/gpu/media/android_copying_backing_strategy.cc
+++ b/content/common/gpu/media/android_copying_backing_strategy.cc
@@ -17,13 +17,6 @@
namespace content {
-// TODO(liberato): It is unclear if we have an issue with deadlock during
-// playback if we lower this. Previously (crbug.com/176036), a deadlock
-// could occur during preroll. More recent tests have shown some
-// instability with kNumPictureBuffers==2 with similar symptoms
-// during playback. crbug.com/:531588 .
-enum { kNumPictureBuffers = media::limits::kMaxVideoFrames + 1 };
-
const static GLfloat kIdentityMatrix[16] = {1.0f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f,
0.0f, 0.0f, 0.0f, 0.0f, 1.0f, 0.0f,
0.0f, 0.0f, 0.0f, 1.0f};
@@ -48,10 +41,6 @@ void AndroidCopyingBackingStrategy::Cleanup(
glDeleteTextures(1, &surface_texture_id_);
}
-uint32 AndroidCopyingBackingStrategy::GetNumPictureBuffers() const {
- return kNumPictureBuffers;
-}
-
uint32 AndroidCopyingBackingStrategy::GetTextureTarget() const {
return GL_TEXTURE_2D;
}

Powered by Google App Engine
This is Rietveld 408576698