Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 14898004: Bluetooth: set a name for the adapter (Closed)

Created:
7 years, 7 months ago by keybuk
Modified:
7 years, 7 months ago
Reviewers:
youngki
CC:
chromium-reviews
Visibility:
Public.

Description

Bluetooth: set a name for the adapter BUG=220820 TEST=bt_console, show R=youngki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198544

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix nit #

Patch Set 3 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1 line) Patch
M device/bluetooth/bluetooth_adapter_experimental_chromeos.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_experimental_chromeos.cc View 1 2 3 chunks +36 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_experimental_chromeos_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
keybuk
7 years, 7 months ago (2013-05-03 17:54:01 UTC) #1
youngki
lgtm https://chromiumcodereview.appspot.com/14898004/diff/1/device/bluetooth/bluetooth_adapter_experimental_chromeos.h File device/bluetooth/bluetooth_adapter_experimental_chromeos.h (right): https://chromiumcodereview.appspot.com/14898004/diff/1/device/bluetooth/bluetooth_adapter_experimental_chromeos.h#newcode98 device/bluetooth/bluetooth_adapter_experimental_chromeos.h:98: // Sets the adapter name to one chosen ...
7 years, 7 months ago (2013-05-03 20:36:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/14898004/4002
7 years, 7 months ago (2013-05-03 20:38:47 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-05-03 21:06:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/14898004/4002
7 years, 7 months ago (2013-05-03 21:07:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) device_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=110929
7 years, 7 months ago (2013-05-04 00:46:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/14898004/36001
7 years, 7 months ago (2013-05-06 17:04:19 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 21:38:21 UTC) #8
Message was sent while issue was closed.
Change committed as 198544

Powered by Google App Engine
This is Rietveld 408576698