Issue 14897004: Skipping {}, () and [] blocks while error recovering in CSS.

Issue 14897004: Skipping {}, () and [] blocks while error recovering in CSS. (Closed)

Created:
7 years, 7 months ago by SeRya

Modified:
7 years, 7 months ago

Reviewers:
TabAtkins, apavlov

CC:
blink-reviews, apavlov+blink_chromium.org, eae+blinkwatch, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Skipping {}, () and [] blocks while error recovering in CSS. This affects recovering in expression, declaration and declaration lists. BUG=140608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150211

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Merge #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -8 lines)			Patch
A	LayoutTests/fast/css/parsing-expr-error-recovery.html	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/parsing-expr-error-recovery-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSGrammar.y.in	View	1 2 3	6 chunks	+24 lines, -8 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

TabAtkins

Heh, I like the test. You test three of the six variants of "block containing ...

7 years, 7 months ago (2013-05-10 21:19:47 UTC) #2

apavlov

Missed one nit in the previous review https://codereview.chromium.org/14897004/diff/10001/LayoutTests/fast/css/parsing-expr-error-recovery.html File LayoutTests/fast/css/parsing-expr-error-recovery.html (right): https://codereview.chromium.org/14897004/diff/10001/LayoutTests/fast/css/parsing-expr-error-recovery.html#newcode25 LayoutTests/fast/css/parsing-expr-error-recovery.html:25: for (test ...

7 years, 7 months ago (2013-05-13 06:59:52 UTC) #4

SeRya

https://codereview.chromium.org/14897004/diff/10001/LayoutTests/fast/css/parsing-expr-error-recovery.html File LayoutTests/fast/css/parsing-expr-error-recovery.html (right): https://codereview.chromium.org/14897004/diff/10001/LayoutTests/fast/css/parsing-expr-error-recovery.html#newcode25 LayoutTests/fast/css/parsing-expr-error-recovery.html:25: for (test = tests.firstChild; test; test = test.nextSibling) { ...

7 years, 7 months ago (2013-05-13 07:17:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/14897004/11004

7 years, 7 months ago (2013-05-13 10:29:12 UTC) #7

Message was sent while issue was closed.

Change committed as 150211

Expand Messages | Collapse Messages