Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14895004: Fixing autocheckout progress bar repaint bug. (Closed)

Created:
7 years, 7 months ago by Dan Beam
Modified:
7 years, 7 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, Raman Kakilate, benquan, tfarina, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Fixing autocheckout progress bar repaint bug. R=estade@chromium.org BUG=none TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199424

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : . #

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 4 5 5 chunks +22 lines, -7 lines 0 comments Download
M ui/views/window/dialog_client_view.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Evan Stade
https://chromiumcodereview.appspot.com/14895004/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://chromiumcodereview.appspot.com/14895004/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode748 chrome/browser/ui/views/autofill/autofill_dialog_views.cc:748: footnote_view_->SetVisible(true); and I think you'll need to move this ...
7 years, 7 months ago (2013-05-07 22:25:10 UTC) #1
Dan Beam
+sky@ for OWNERS (will wait for estade@'s review as well) https://chromiumcodereview.appspot.com/14895004/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc File chrome/browser/ui/views/autofill/autofill_dialog_views.cc (right): https://chromiumcodereview.appspot.com/14895004/diff/1/chrome/browser/ui/views/autofill/autofill_dialog_views.cc#newcode748 ...
7 years, 7 months ago (2013-05-08 00:54:09 UTC) #2
Evan Stade
lgtm https://chromiumcodereview.appspot.com/14895004/diff/8001/chrome/browser/ui/views/autofill/autofill_dialog_views.h File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): https://chromiumcodereview.appspot.com/14895004/diff/8001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode413 chrome/browser/ui/views/autofill/autofill_dialog_views.h:413: class ButtonStripView : public views::View { put this ...
7 years, 7 months ago (2013-05-08 22:27:56 UTC) #3
Evan Stade
also relevant: https://chromiumcodereview.appspot.com/15071002/ (you wouldn't need the special ButtonStripView)
7 years, 7 months ago (2013-05-08 22:33:05 UTC) #4
Dan Beam
sky@: ping, quick review for I/O justice
7 years, 7 months ago (2013-05-09 17:57:58 UTC) #5
Dan Beam
https://chromiumcodereview.appspot.com/14895004/diff/8001/chrome/browser/ui/views/autofill/autofill_dialog_views.h File chrome/browser/ui/views/autofill/autofill_dialog_views.h (right): https://chromiumcodereview.appspot.com/14895004/diff/8001/chrome/browser/ui/views/autofill/autofill_dialog_views.h#newcode413 chrome/browser/ui/views/autofill/autofill_dialog_views.h:413: class ButtonStripView : public views::View { On 2013/05/08 22:27:56, ...
7 years, 7 months ago (2013-05-09 18:32:30 UTC) #6
sky
LGTM - we'll retrofit if we go with Evan's other CL.
7 years, 7 months ago (2013-05-09 19:13:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/14895004/22002
7 years, 7 months ago (2013-05-09 22:38:03 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=38626
7 years, 7 months ago (2013-05-10 01:18:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/14895004/22002
7 years, 7 months ago (2013-05-10 04:03:02 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 07:54:50 UTC) #11
Message was sent while issue was closed. 
Change committed as 199424

Powered by Google App Engine
This is Rietveld 408576698