Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
14890029:
Add split-dll build to main waterfall (Closed)
|
Created:
7 years, 7 months ago by scottmg Modified:
7 years, 7 months ago CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org Visibility:
Public. |
DescriptionAdd split-dll build to main waterfall
BUG=241097
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=201631
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Total comments: 9
Patch Set 4 : #Patch Set 5 : #Patch Set 6 : #Patch Set 7 : #Messages
Total messages: 14 (0 generated)
\noideawhatimdoing{}
This is supposed to be a ninja Release builder with an extra GYP_DEFINES of
chrome_split_dll=1 set, and having that script run at the end that checks for
regressions.
On 2013/05/15 16:34:08, scottmg wrote:
> \noideawhatimdoing{}
>
> This is supposed to be a ninja Release builder with an extra GYP_DEFINES of
> chrome_split_dll=1 set, and having that script run at the end that checks for
> regressions.
Do we really want this on master.chromium?
On 2013/05/16 07:56:55, iannucci wrote:
> On 2013/05/15 16:34:08, scottmg wrote:
> > \noideawhatimdoing{}
> >
> > This is supposed to be a ninja Release builder with an extra GYP_DEFINES of
> > chrome_split_dll=1 set, and having that script run at the end that checks
for
> > regressions.
>
> Do we really want this on master.chromium?
We're going to try to ship it to Canary in the next week or so, so it needs to
be on the main waterfall. Should it go on chromium.win instead? I'm not really
sure what the distinction is.
+cmp what do you think?
ping, removed the script for now to simplify. just want to get the split_link builder up so we know if it's reasonable try to push this to canary.
To get this added to a real and useful sizes check, it'll need to be on master.chromium. SGTM.
https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... File masters/master.chromium/master_full_cfg.py (right): https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:21: def win(): return chromium_factory.ChromiumFactory('src/build', 'win32') add a win_out() which has build_dir set to 'src/out' https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:62: F('win_split', win().ChromiumFactory( use it here https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:64: options=['--build-tool=ninja'] Do you want to specify the targets to build a la the linux_clobber builder below? https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:70: 'GYP_DEFINES': 'fastbuild=1 chrome_split_dll=1', I think you need GYP_GENERATORS=ninja here
Thanks https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... File masters/master.chromium/master_full_cfg.py (right): https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:21: def win(): return chromium_factory.ChromiumFactory('src/build', 'win32') On 2013/05/22 22:39:47, iannucci1 wrote: > add a win_out() which has build_dir set to 'src/out' Done. https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:62: F('win_split', win().ChromiumFactory( On 2013/05/22 22:39:47, iannucci1 wrote: > use it here Done. https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:64: options=['--build-tool=ninja'] On 2013/05/22 22:39:47, iannucci1 wrote: > Do you want to specify the targets to build a la the linux_clobber builder > below? Sorry, not sure what you mean here. Adding a 'tests' block? I wanted to just get the building up first, but maybe what I could do is also add the script, but make it always pass for now so that we don't need another restart later. Did that. https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:70: 'GYP_DEFINES': 'fastbuild=1 chrome_split_dll=1', On 2013/05/22 22:39:47, iannucci1 wrote: > I think you need GYP_GENERATORS=ninja here Done.
https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... File masters/master.chromium/master_full_cfg.py (right): https://codereview.chromium.org/14890029/diff/7001/masters/master.chromium/ma... masters/master.chromium/master_full_cfg.py:64: options=['--build-tool=ninja'] On 2013/05/22 22:48:27, scottmg wrote: > On 2013/05/22 22:39:47, iannucci1 wrote: > > Do you want to specify the targets to build a la the linux_clobber builder > > below? > > Sorry, not sure what you mean here. Adding a 'tests' block? I wanted to just get > the building up first, but maybe what I could do is also add the script, but > make it always pass for now so that we don't need another restart later. Did > that. > > Meaning, do you want to compile something specific as opposed to the default build set (maybe All or chromium_builder_tests?)
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/14890029/21003
Presubmit check for 14890029-21003 failed and returned exit status 1. INFO:root:Found 2 file(s). INFO:PRESUBMIT:Running pylint on 379 files Running presubmit commit checks ... Running /b/commit-queue/workdir/tools/build/PRESUBMIT.py Running test/masters_util_list_test.py Running test/masters_test.py Running test/tryserver_mail_test.py Running test/masters_cfg_test.py Running test/slaves_cfg_test.py Running scripts/master/unittests/failures_notifier_test.py Running scripts/master/unittests/gatekeeper_test.py Running scripts/master/unittests/failures_history_test.py Running scripts/master/unittests/chromium_utils_test.py Running scripts/master/unittests/try_job_base_test.py Running scripts/master/unittests/chromium_notifier_test.py Running scripts/master/unittests/perf_count_notifier_test.py Running scripts/master/unittests/gclient_source_test.py Running scripts/master/unittests/process_log_test.py Running scripts/master/unittests/chromium_commands_test.py Running scripts/master/unittests/annotator_test.py Running scripts/slave/unittests/get_swarm_results_test.py Running scripts/slave/unittests/runisolatedtest_test.py Running scripts/slave/unittests/extract_build_test.py Running scripts/slave/unittests/recipe_util_test.py Running scripts/slave/unittests/telemetry_test.py Running scripts/slave/unittests/buildrunner_test.py Running scripts/slave/unittests/runtest_annotator_test.py Running scripts/slave/unittests/cleanup_old_files_test.py Running scripts/slave/unittests/recipes_test.py Running scripts/slave/unittests/results_dashboard_test.py Running scripts/common/unittests/gtest_utils_test.py Running scripts/common/unittests/annotator_test.py Running scripts/tools/unittests/lkgr_finder_test.py ** Presubmit ERRORS ** Pylint (379 files) failed ************* Module master_full_cfg E0001: 66,0: invalid syntax test/masters_test.py failed 1 masters failed: master.chromium 54 masters succeeded, 1 failed, 1 skipped in 10.8s. === Error running master.chromium === 2013-05-22 16:11:06-0700 [-] Applying patch for http://twistedmatrix.com/trac/ticket/5079 2013-05-22 16:11:06-0700 [-] Creating BuildMaster -- buildbot.version: 0.8.4p1 2013-05-22 16:11:06-0700 [-] loading configuration from /b/commit-queue/workdir/tools/build/masters/master.chromium/master.cfg 2013-05-22 16:11:06-0700 [-] configuration update started 2013-05-22 16:11:07-0700 [-] error while parsing config file 2013-05-22 16:11:07-0700 [-] Unhandled Error Traceback (most recent call last): File "/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/master.py", line 248, in loadTheConfigFile d = self.loadConfig(f) File "/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/master.py", line 602, in loadConfig d.addCallback(do_load) File "/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/internet/defer.py", line 297, in addCallback callbackKeywords=kw) File "/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/internet/defer.py", line 286, in addCallbacks self._runCallbacks() --- <exception caught here> --- File "/b/commit-queue/workdir/tools/build/third_party/twisted_10_2/twisted/internet/defer.py", line 542, in _runCallbacks current.result = callback(current.result, *args, **kw) File "/b/commit-queue/workdir/tools/build/third_party/buildbot_8_4p1/buildbot/master.py", line 277, in do_load exec f in localDict File "/b/commit-queue/workdir/tools/build/masters/master.chromium/master.cfg", line 26, in <module> import master_full_cfg exceptions.SyntaxError: invalid syntax (master_full_cfg.py, line 66) test/masters_cfg_test.py failed /b/commit-queue/workdir/tools/build/masters/master.chromium.lkgr > WARNING: Passed "src/build" as --build-dir option on darwin. This is almost certainly incorrect. > Assuming you meant "src/xcodebuild" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" /b/commit-queue/workdir/tools/build/masters/master.chromium.fyi > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" > WARNING: Passed "src/build" as --build-dir option on linux. This is almost certainly incorrect. > Assuming you meant "src/out" FAILURE The following master.cfg files did not load: /b/commit-queue/workdir/tools/build/masters/master.chromium > error while parsing /b/commit-queue/workdir/tools/build/masters/master.chromium/master.cfg: > Traceback (most recent call last): > File "/b/commit-queue/workdir/tools/build/scripts/common/master_cfg_utils.py", line 76, in LoadConfig > localdict = ExecuteConfig(canonical_config) > File "/b/commit-queue/workdir/tools/build/scripts/common/master_cfg_utils.py", line 50, in ExecuteConfig > exec f in localDict > File "/b/commit-queue/workdir/tools/build/masters/master.chromium/master.cfg", line 26, in <module> > import master_full_cfg > File "/b/commit-queue/workdir/tools/build/masters/master.chromium/master_full_cfg.py", line 66 > factory_properties={ > ^ > SyntaxError: invalid syntax > > build error encountered! aborting build Parsed 54 masters successfully, 1 failed, 2 skipped in 10s. Presubmit checks took 38.0s to calculate. Was the presubmit check useful? Please send feedback & hate mail to maruel@chromium.org!
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/14890029/25001
Message was sent while issue was closed.
Change committed as 201631 |
