Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: build/common.gypi

Issue 14890022: Enable Clang warnings in implementation files for OS X (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1539 matching lines...) Expand 10 before | Expand all | Expand 10 after
1550 ['use_concatenated_impulse_responses==1', { 1550 ['use_concatenated_impulse_responses==1', {
1551 'grit_defines': ['-D', 'use_concatenated_impulse_responses'], 1551 'grit_defines': ['-D', 'use_concatenated_impulse_responses'],
1552 }], 1552 }],
1553 ['clang_use_chrome_plugins==1 and OS!="win"', { 1553 ['clang_use_chrome_plugins==1 and OS!="win"', {
1554 'variables': { 1554 'variables': {
1555 'clang_chrome_plugins_flags': [ 1555 'clang_chrome_plugins_flags': [
1556 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)' 1556 '<!@(<(DEPTH)/tools/clang/scripts/plugin_flags.sh)'
1557 ], 1557 ],
1558 }, 1558 },
1559 'conditions': [ 1559 'conditions': [
1560 ['OS=="linux"', { 1560 ['OS=="linux" or OS=="mac"', {
1561 'clang_chrome_plugins_flags': [ 1561 'clang_chrome_plugins_flags': [
1562 '<@(clang_chrome_plugins_flags)' 1562 '<@(clang_chrome_plugins_flags)'
1563 ], 1563 ],
1564 }, { 1564 }, {
1565 # TODO(rsleevi): http://crbug.com/115047 - This warning is only 1565 # TODO(rsleevi): http://crbug.com/115047 - This warning is only
1566 # enabled for Linux for now. Disable everywhere else. 1566 # enabled for Linux for now. Disable everywhere else.
1567 'clang_chrome_plugins_flags': [ 1567 'clang_chrome_plugins_flags': [
1568 '<@(clang_chrome_plugins_flags)', 1568 '<@(clang_chrome_plugins_flags)',
1569 '-Xclang', 1569 '-Xclang',
1570 '-plugin-arg-find-bad-constructs', 1570 '-plugin-arg-find-bad-constructs',
(...skipping 2881 matching lines...) Expand 10 before | Expand all | Expand 10 after
4452 # settings in target dicts. SYMROOT is a special case, because many other 4452 # settings in target dicts. SYMROOT is a special case, because many other
4453 # Xcode variables depend on it, including variables such as 4453 # Xcode variables depend on it, including variables such as
4454 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4454 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4455 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4455 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4456 # files to appear (when present) in the UI as actual files and not red 4456 # files to appear (when present) in the UI as actual files and not red
4457 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4457 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4458 # and therefore SYMROOT, needs to be set at the project level. 4458 # and therefore SYMROOT, needs to be set at the project level.
4459 'SYMROOT': '<(DEPTH)/xcodebuild', 4459 'SYMROOT': '<(DEPTH)/xcodebuild',
4460 }, 4460 },
4461 } 4461 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698