Issue 14890022: Enable Clang warnings in implementation files for OS X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14890022: Enable Clang warnings in implementation files for OS X (Closed)

Created:
7 years, 7 months ago by Ryan Sleevi

Modified:
7 years, 7 months ago

Reviewers:
Nico, (unused - use chromium)

CC:
chromium-reviews, Aaron Boodman, sail+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable Clang warnings in implementation files for OS X BUG=115047 R=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199568

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	build/common.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

thakis: rubberstamp and CQ for the (hope it sticks this time) win?

7 years, 7 months ago (2013-05-10 00:42:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14890022/1

7 years, 7 months ago (2013-05-10 01:45:06 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=146571

7 years, 7 months ago (2013-05-10 06:01:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14890022/1

7 years, 7 months ago (2013-05-10 23:19:20 UTC) #5

Message was sent while issue was closed.

Change committed as 199568

Expand Messages | Collapse Messages