Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 14890005: Enable Clang warnings in .cc files for Linux+[Aura/ChromeOS] (Closed)

Created:
7 years, 7 months ago by Ryan Sleevi
Modified:
7 years, 7 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ahutter, dcheng, Albert Bodenhamer, Ilya Sherman, ben+watch_chromium.org, benquan, stevenjb+watch_chromium.org, jam, dbeam+watch-autofill_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, Raman Kakilate, tfarina, Aaron Boodman, Dane Wallinga, dyu1, estade+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Enable Clang warnings in .cc files for Linux+[Aura/ChromeOS] BUG=115047 R=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198649

Patch Set 1 #

Patch Set 2 : Slight rebase tweak #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -39 lines) Patch
M ash/focus_cycler_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/variations_service_policy_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/statistics_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/notifications_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/cryptohome/cryptohome_library.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/experimental_bluetooth_input_client.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chromeos/network/network_state_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_experimental_chromeos_unittest.cc View 1 2 1 chunk +10 lines, -11 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ryan Sleevi
darin: Another sweeping but purely mechanical CL that spans enough OWNERS to be a pain. ...
7 years, 7 months ago (2013-05-03 01:17:49 UTC) #1
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-03 06:08:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/14890005/9001
7 years, 7 months ago (2013-05-07 00:32:23 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 06:24:29 UTC) #4
Message was sent while issue was closed.
Change committed as 198649

Powered by Google App Engine
This is Rietveld 408576698