Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 14885021: Cleanup: Prefix HTML5 Sandbox FileSystem related files with 'sandbox_' (Closed)

Created:
7 years, 7 months ago by kinuko
Modified:
7 years, 7 months ago
Reviewers:
Avi (use Gerrit), tzik
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Prefix HTML5 Sandbox FileSystem related files with 'sandbox_' Except for obfuscated_file_util* for now. (I'll make a separate patch when I do so) BUG=240658 TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -2787 lines) Patch
M content/content_tests.gypi View 1 chunk +7 lines, -7 lines 0 comments Download
M webkit/fileapi/dump_file_system.cc View 5 chunks +12 lines, -12 lines 0 comments Download
D webkit/fileapi/file_system_database_test_helper.h View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/fileapi/file_system_database_test_helper.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D webkit/fileapi/file_system_directory_database.h View 1 chunk +0 lines, -122 lines 0 comments Download
D webkit/fileapi/file_system_directory_database.cc View 1 chunk +0 lines, -922 lines 0 comments Download
D webkit/fileapi/file_system_directory_database_unittest.cc View 1 chunk +0 lines, -676 lines 0 comments Download
D webkit/fileapi/file_system_origin_database.h View 1 chunk +0 lines, -82 lines 0 comments Download
D webkit/fileapi/file_system_origin_database.cc View 1 chunk +0 lines, -333 lines 0 comments Download
D webkit/fileapi/file_system_origin_database_unittest.cc View 1 chunk +0 lines, -306 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.h View 5 chunks +9 lines, -9 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 26 chunks +32 lines, -32 lines 0 comments Download
A + webkit/fileapi/sandbox_database_test_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/fileapi/sandbox_database_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/fileapi/sandbox_directory_database.h View 6 chunks +12 lines, -10 lines 0 comments Download
A + webkit/fileapi/sandbox_directory_database.cc View 33 chunks +47 lines, -43 lines 0 comments Download
A + webkit/fileapi/sandbox_directory_database_unittest.cc View 31 chunks +44 lines, -42 lines 0 comments Download
A + webkit/fileapi/sandbox_origin_database.h View 4 chunks +8 lines, -8 lines 0 comments Download
A + webkit/fileapi/sandbox_origin_database.cc View 11 chunks +21 lines, -21 lines 0 comments Download
A + webkit/fileapi/sandbox_origin_database_unittest.cc View 11 chunks +26 lines, -25 lines 0 comments Download
M webkit/fileapi/webkit_fileapi.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kinuko
Sorry for spamming, I picked another one. PTL
7 years, 7 months ago (2013-05-15 09:30:50 UTC) #1
tzik
lgtm
7 years, 7 months ago (2013-05-15 10:24:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/14885021/1
7 years, 7 months ago (2013-05-15 13:59:21 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=3039
7 years, 7 months ago (2013-05-15 14:10:56 UTC) #4
kinuko
TBR-ing avi@ for file renaming change in content/content_tests.gypi. (Please warn me if this type of ...
7 years, 7 months ago (2013-05-16 05:57:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/14885021/1
7 years, 7 months ago (2013-05-16 05:57:45 UTC) #6
commit-bot: I haz the power
Change committed as 200507
7 years, 7 months ago (2013-05-16 10:46:52 UTC) #7
Avi (use Gerrit)
For a change like that, I don't mind TBRs. Anything more complicated just ask.
7 years, 7 months ago (2013-05-16 14:24:29 UTC) #8
Avi (use Gerrit)
lgtm
7 years, 7 months ago (2013-05-16 14:24:39 UTC) #9
kinuko
7 years, 7 months ago (2013-05-16 14:32:06 UTC) #10
Message was sent while issue was closed.
On 2013/05/16 14:24:29, Avi wrote:
> For a change like that, I don't mind TBRs. Anything more complicated just ask.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698