Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14880002: Fixes a memory leak when running webrtc-internals for a long time, by using a circular buffer of si… (Closed)

Created:
7 years, 7 months ago by jiayl
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixes a memory leak when running webrtc-internals for a long time, by using a circular buffer of size 1k for stats data points. Also explicitly draws the graph time labels 1min apart in a 5min range. BUG=230250 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199008 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199193

Patch Set 1 : #

Patch Set 2 : fix merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -36 lines) Patch
M content/browser/media/webrtc_internals_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/media/data_series.js View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/resources/media/stats_graph_helper.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/resources/media/timeline_graph_view.js View 1 chunk +2 lines, -35 lines 0 comments Download
M content/browser/resources/media/webrtc_internals.js View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vrk (LEFT CHROMIUM)
lgtm
7 years, 7 months ago (2013-05-07 19:52:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/14880002/2001
7 years, 7 months ago (2013-05-07 19:57:25 UTC) #2
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125239
7 years, 7 months ago (2013-05-07 21:04:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/14880002/2001
7 years, 7 months ago (2013-05-07 21:06:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125310
7 years, 7 months ago (2013-05-07 21:45:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/14880002/2001
7 years, 7 months ago (2013-05-07 22:02:01 UTC) #6
commit-bot: I haz the power
Change committed as 199008
7 years, 7 months ago (2013-05-08 21:26:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/14880002/35001
7 years, 7 months ago (2013-05-08 23:40:28 UTC) #8
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 12:38:54 UTC) #9
Message was sent while issue was closed. 
Change committed as 199193

Powered by Google App Engine
This is Rietveld 408576698