Minor SimpleCacheBackend improvements.

net/disk_cache/simple/simple_index.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_DISK_CACHE_SIMPLE_SIMPLE_INDEX_H_
 #define NET_DISK_CACHE_SIMPLE_SIMPLE_INDEX_H_
 
 #include <list>
 #include <string>
 #include <vector>
@@ skipping 120 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(SimpleIndexTest, IsIndexFileStale);
   FRIEND_TEST_ALL_PREFIXES(SimpleIndexTest, IndexSizeCorrectOnMerge);
   typedef base::Callback<void(scoped_ptr<EntrySet>, bool force_index_flush)>
       IndexCompletionCallback;
 
   void StartEvictionIfNeeded();
   void EvictionDone(scoped_ptr<int> result);
 
   void PostponeWritingToDisk();
 
+  void UpdateEntryIteratorSize(EntrySet::iterator* it, uint64 entry_size);
+
   // Using the mtime of the file and its mtime, detects if the index file is
   // stale.
   static bool IsIndexFileStale(const base::FilePath& index_filename);
 
   static void InitializeInternal(
       const base::FilePath& index_filename,
       base::SingleThreadTaskRunner* io_thread,
       const IndexCompletionCallback& completion_callback);
 
   // Enumerates all entries' files on disk and regenerates the index.
@@ skipping 36 matching lines @@
 
   // All nonstatic SimpleEntryImpl methods should always be called on the IO
   // thread, in all cases. |io_thread_checker_| documents and enforces this.
   base::ThreadChecker io_thread_checker_;
 
   // Timestamp of the last time we wrote the index to disk.
   // PostponeWritingToDisk() may give up postponing and allow the write if it
   // has been a while since last time we wrote.
   base::TimeTicks last_write_to_disk_;
   base::OneShotTimer<SimpleIndex> write_to_disk_timer_;
+  base::Closure write_to_disk_cb_;

[pasko, 2013/05/17 10:31:33]

nit: please separate the declaration of last_write_to_disk_ from the next two
declarations by one empty line.

[digit1, 2013/05/17 14:36:18]

Done.

 
   typedef std::list<net::CompletionCallback> CallbackList;
   CallbackList to_run_when_initialized_;
 
   // Set to true when the app is on the background. When the app is in the
   // background we can write the index much more frequently, to insure fresh
   // index on next startup.
   bool app_on_background_;
 };
 
 }  // namespace disk_cache
 
 #endif  // NET_DISK_CACHE_SIMPLE_SIMPLE_INDEX_H_