Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 14877009: Revert r196089 "Add default values for Latin script font prefs." (Closed)

Created:
7 years, 7 months ago by falken
Modified:
7 years, 7 months ago
CC:
chromium-reviews, finnur+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Revert r196089 "Add default values for Latin script font prefs." Reverting because it caused bug 237258. Many sites set lang="en" which cause the Latin font prefs to be used, and it's surprising to users that chrome://settings/fonts is not respected. We need a more obvious way to customize per-script fonts first. BUG=237258 TBR=bauerb Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199398

Patch Set 1 #

Patch Set 2 : new partch after syncing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -238 lines) Patch
M chrome/app/resources/locale_settings_chromiumos.grd View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/app/resources/locale_settings_google_chromeos.grd View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/app/resources/locale_settings_linux.grd View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/app/resources/locale_settings_mac.grd View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
falken
Hi Jungshik, I think we have to land this revert for now. I imagine lots ...
7 years, 7 months ago (2013-05-07 10:57:36 UTC) #1
jungshik at Google
Do you want to revert the whole thing or want to keep ChromeOS part? It's ...
7 years, 7 months ago (2013-05-09 18:12:05 UTC) #2
falken
On 2013/05/09 18:12:05, Jungshik Shin wrote: > Do you want to revert the whole thing ...
7 years, 7 months ago (2013-05-10 01:40:58 UTC) #3
falken
TBR'ing prefs OWNER bauerb as this change is just a revert.
7 years, 7 months ago (2013-05-10 02:06:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/14877009/4002
7 years, 7 months ago (2013-05-10 02:07:19 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 06:03:36 UTC) #6
Message was sent while issue was closed.
Change committed as 199398

Powered by Google App Engine
This is Rietveld 408576698