Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_unittest.cc

Issue 14876034: Enable Clang warnings for implementation files on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gypi style tweak Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/tab_model/tab_model_unittest.cc
diff --git a/chrome/browser/ui/android/tab_model/tab_model_unittest.cc b/chrome/browser/ui/android/tab_model/tab_model_unittest.cc
index b6395584a8b9b20770c444da35deb0e3070d734f..439b2bc5fb4f5d1c37e8ca0515d52c33f91fce57 100644
--- a/chrome/browser/ui/android/tab_model/tab_model_unittest.cc
+++ b/chrome/browser/ui/android/tab_model/tab_model_unittest.cc
@@ -28,15 +28,15 @@ class TestTabModel : public TabModel {
explicit TestTabModel(Profile* profile)
: TabModel(profile) {}
- int GetTabCount() const OVERRIDE { return 0; }
- int GetActiveIndex() const OVERRIDE { return 0; }
- content::WebContents* GetWebContentsAt(int index) const OVERRIDE {
+ virtual int GetTabCount() const OVERRIDE { return 0; }
+ virtual int GetActiveIndex() const OVERRIDE { return 0; }
+ virtual content::WebContents* GetWebContentsAt(int index) const OVERRIDE {
return NULL;
}
- SessionID::id_type GetTabIdAt(int index) const OVERRIDE { return 0; }
- void CreateTab(content::WebContents* web_contents) OVERRIDE {}
- bool IsSessionRestoreInProgress() const OVERRIDE { return false; }
- void OpenClearBrowsingData() const OVERRIDE {}
+ virtual SessionID::id_type GetTabIdAt(int index) const OVERRIDE { return 0; }
+ virtual void CreateTab(content::WebContents* web_contents) OVERRIDE {}
+ virtual bool IsSessionRestoreInProgress() const OVERRIDE { return false; }
+ virtual void OpenClearBrowsingData() const OVERRIDE {}
};
TEST_F(TabModelTest, TestProfileHandling) {
« no previous file with comments | « chrome/browser/history/android/visit_sql_handler_unittest.cc ('k') | content/app/android/child_process_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698