Add speech synthesizer tests (from WebKit).

Add speech synthesizer tests (from WebKit).

Also marks speech synthesis as "experimental" in runtime features,
so that it can be tested.

BUG=171887
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150163

[dmazzoni, 2013-05-10 16:25:16]

This is the change that's triggering the derefObjectFunction assertion failure.

[Tom Sepez, 2013-05-10 16:40:19]

Not sure why I was asked to review this, you probably still need an OWNER.
LGTM with nits.

https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
File LayoutTests/fast/speechsynthesis/speech-synthesis-cancel.html (right):

https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
LayoutTests/fast/speechsynthesis/speech-synthesis-cancel.html:48:
setTimeout("speechSynthesis.cancel()", "1");
nit: "1" vs. 1.

https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
File LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html
(right):

https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html:46:
setTimeout("speechSynthesis.pause()", "1");
nit: "1" vs 1.

https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html:47:
setTimeout("speechSynthesis.resume()", "2");
nit: "2" vs 2.

[dmazzoni, 2013-05-10 16:57:52]

Thanks! Sorry, I sent you a separate email but didn't make it
clear - I'm hitting the derefObjectFunction assert you just
added in https://codereview.chromium.org/14520011/ - could
you help me figure out why?

ASSERTION FAILED: actualInfo->derefObjectFunction ==
V8SpeechSynthesisEvent::info.derefObjectFunction
gen/webkit/bindings/V8SpeechSynthesisEvent.h(70) : v8::Handle<v8::Object>
WebCore::wrap(WebCore::SpeechSynthesisEvent *, v8::Handle<v8::Object>,
v8::Isolate *)
1   0x4575993 WebCore::wrap(WebCore::SpeechSynthesisEvent*,
v8::Handle<v8::Object>, v8::Isolate*)
2   0x4570470 WebCore::wrap(WebCore::Event*, v8::Handle<v8::Object>,
v8::Isolate*)
3   0x454818e WebCore::toV8(WebCore::Event*, v8::Handle<v8::Object>,
v8::Isolate*)
4   0x44f281e
WebCore::V8AbstractEventListener::handleEvent(WebCore::ScriptExecutionContext*,
WebCore::Event*)
5   0x390bf09 WebCore::EventTarget::fireEventListeners(WebCore::Event*,
WebCore::EventTargetData*, WTF::Vector<WebCore::RegisteredEventListener, 1ul>&)
6   0x390ba31 WebCore::EventTarget::fireEventListeners(WebCore::Event*)
7   0x390b7ff
WebCore::EventTarget::dispatchEvent(WTF::PassRefPtr<WebCore::Event>)
8   0x1bbf850 WebCore::SpeechSynthesis::fireEvent(WTF::AtomicString const&,
WebCore::SpeechSynthesisUtterance*, unsigned long, WTF::String const&)
9   0x1bbfe57
WebCore::SpeechSynthesis::didStartSpeaking(WTF::PassRefPtr<WebCore::PlatformSpeechSynthesisUtterance>)
10  0x2c828a7
WebCore::PlatformSpeechSynthesizerMock::speak(WTF::PassRefPtr<WebCore::PlatformSpeechSynthesisUtterance>)

On 2013/05/10 16:40:19, Tom Sepez wrote:
> Not sure why I was asked to review this, you probably still need an OWNER.
> LGTM with nits.
> 
>
https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
> File LayoutTests/fast/speechsynthesis/speech-synthesis-cancel.html (right):
> 
>
https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
> LayoutTests/fast/speechsynthesis/speech-synthesis-cancel.html:48:
> setTimeout("speechSynthesis.cancel()", "1");
> nit: "1" vs. 1.
> 
>
https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
> File LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html
> (right):
> 
>
https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
> LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html:46:
> setTimeout("speechSynthesis.pause()", "1");
> nit: "1" vs 1.
> 
>
https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
> LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html:47:
> setTimeout("speechSynthesis.resume()", "2");
> nit: "2" vs 2.

[dmazzoni, 2013-05-10 18:05:23]

+eseidel

@tsepez: Thanks for finding the missing ScriptWrappable::init, that fixed it.

Ready for review.

https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
File LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html
(right):

https://codereview.chromium.org/14874017/diff/1/LayoutTests/fast/speechsynthe...
LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html:46:
setTimeout("speechSynthesis.pause()", "1");
On 2013/05/10 16:40:19, Tom Sepez wrote:
> nit: "1" vs 1.

Fixed throughout, thanks.

[eseidel, 2013-05-10 23:43:29]

lgtm

https://codereview.chromium.org/14874017/diff/6001/Source/core/page/RuntimeEn...
File Source/core/page/RuntimeEnabledFeatures.in (right):

https://codereview.chromium.org/14874017/diff/6001/Source/core/page/RuntimeEn...
Source/core/page/RuntimeEnabledFeatures.in:57: 
This will make it enabled for users with about:flags
--enable-experimental-features.  That's fine.  Just making sure that's your
intent.

[commit-bot: I haz the power, 2013-05-10 23:43:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14874017/6001

[commit-bot: I haz the power, 2013-05-11 00:56:23]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-11 07:20:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14874017/6001

[commit-bot: I haz the power, 2013-05-11 08:06:10]

Retried try job too often on linux_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...

[commit-bot: I haz the power, 2013-05-11 09:59:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14874017/6001

[commit-bot: I haz the power, 2013-05-11 09:59:52]

Change committed as 150163