Fixed CPU info reporting on ChromeOS ARM.

Fixed CPU model name reporting on ChromeOS/ARM.

BUG=237294
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198378

[darin (slow to review), 2013-05-03 06:07:09]

https://codereview.chromium.org/14872004/diff/1001/base/sys_info_linux.cc
File base/sys_info_linux.cc (right):

https://codereview.chromium.org/14872004/diff/1001/base/sys_info_linux.cc#new...
base/sys_info_linux.cc:76: #if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL)
nit: #ifdefs suck.  i'd be tempted to generalize this code into a helper
function that takes a string parameter.  that way you can just #ifdef once.

at the very least it seems like you could use a more generic local variable name
like kPrefix.

[zel, 2013-05-03 18:02:16]

https://codereview.chromium.org/14872004/diff/1001/base/sys_info_linux.cc
File base/sys_info_linux.cc (right):

https://codereview.chromium.org/14872004/diff/1001/base/sys_info_linux.cc#new...
base/sys_info_linux.cc:76: #if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL)
On 2013/05/03 06:07:09, darin wrote:
> nit: #ifdefs suck.  i'd be tempted to generalize this code into a helper
> function that takes a string parameter.  that way you can just #ifdef once.
> 
> at the very least it seems like you could use a more generic local variable
name
> like kPrefix.

Down to one #ifdef now. Even if I split this in a separate function, there will
be still one #ifdef somewhere else.

[darin (slow to review), 2013-05-03 21:25:33]

LGTM

[commit-bot: I haz the power, 2013-05-03 22:18:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zelidrag@chromium.org/14872004/6001

[commit-bot: I haz the power, 2013-05-06 05:35:33]

Change committed as 198378