Issue 14871008: Remove RenderFrameBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14871008: Remove RenderFrameBase. (Closed)

Created:
7 years, 7 months ago by Mike West

Modified:
7 years, 7 months ago

Reviewers:
kenneth.r.christiansen

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Remove RenderFrameBase. After r150495, RenderFrameBase is just an empty shell. This patch removes it entirely: RenderIFrame and RenderFrame now inherit directly from RenderPart. BUG=231902 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150506

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -99 lines)			Patch
M	Source/core/core.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderFrame.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderFrame.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
D	Source/core/rendering/RenderFrameBase.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	Source/core/rendering/RenderFrameBase.cpp	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	Source/core/rendering/RenderIFrame.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderIFrame.cpp	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderPart.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/14871008/1

7 years, 7 months ago (2013-05-16 11:04:04 UTC) #2

Message was sent while issue was closed.

Change committed as 150506