Enable proper zooming of checkbox and radio button on Win and Mac.

Enable proper zooming of checkbox and radio button on Win and Mac.

This patch enables zooming of checkbox and radio button on Win and Mac by using the fallback theme.

RenderTheme::shouldUseFallbackTheme(): Return true if the fallback theme should be used to render the control.

TEST=Covered by layout tests radio-basic-appearance.html and checkbox-basic-appearance.html 
BUG=84973
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151219

[keishi, 2013-05-16 11:55:12]

This patch depends on https://codereview.chromium.org/14424007/ but it was
reverted.

[tkent, 2013-05-17 03:49:29]

https://codereview.chromium.org/14866009/diff/1/Source/core/rendering/RenderT...
File Source/core/rendering/RenderTheme.cpp (right):

https://codereview.chromium.org/14866009/diff/1/Source/core/rendering/RenderT...
Source/core/rendering/RenderTheme.cpp:1269: if (zoomLevel != 1) {
Do we need this special handing for zoom!=1 ?
It seems the current native_theme_base.cc supports radio/checkbox in arbitrary
size.

https://codereview.chromium.org/14866009/diff/1/Source/core/rendering/RenderT...
Source/core/rendering/RenderTheme.cpp:1311: if (zoomLevel != 1) {
ditto.

[keishi, 2013-05-17 05:35:30]

On 2013/05/17 03:49:29, tkent wrote:
>
https://codereview.chromium.org/14866009/diff/1/Source/core/rendering/RenderT...
> File Source/core/rendering/RenderTheme.cpp (right):
> 
>
https://codereview.chromium.org/14866009/diff/1/Source/core/rendering/RenderT...
> Source/core/rendering/RenderTheme.cpp:1269: if (zoomLevel != 1) {
> Do we need this special handing for zoom!=1 ?
> It seems the current native_theme_base.cc supports radio/checkbox in arbitrary
> size.
If you don't transform the context the border and shadow won't be scaled.
The left is drawn with this patch, the right is drawn with the zoomed rect.
https://docs.google.com/file/d/0BwRi59l_ri74eVpfT3o5aUVSd0E/edit?usp=sharing

[tkent, 2013-05-17 05:40:17]

lgtm.

> If you don't transform the context the border and shadow won't be scaled.
> The left is drawn with this patch, the right is drawn with the zoomed rect.
> https://docs.google.com/file/d/0BwRi59l_ri74eVpfT3o5aUVSd0E/edit?usp=sharing

ok, I understand.
BTW, please reply with the inline comment feature of Rietveld.

[commit-bot: I haz the power, 2013-05-24 07:59:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/14866009/8001

[commit-bot: I haz the power, 2013-05-24 09:20:59]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_layout_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-27 01:48:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/14866009/24001

[commit-bot: I haz the power, 2013-05-27 03:09:46]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-27 12:43:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/14866009/36001

[commit-bot: I haz the power, 2013-05-27 12:43:08]

Can't process patch for file
LayoutTests/platform/chromium-mac/fast/forms/checkbox/checkbox-appearance-basic-expected.png.
Binary file support is temporarilly disabled due to a bug. Please commit blindly
the binary files first then commit the source change as a separate CL. Sorry for
the annoyance.

[commit-bot: I haz the power, 2013-05-28 02:08:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/14866009/41001

[commit-bot: I haz the power, 2013-05-28 04:24:26]

Retried try job too often on win_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[commit-bot: I haz the power, 2013-05-28 04:58:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/14866009/41001

[commit-bot: I haz the power, 2013-05-28 05:03:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keishi@chromium.org/14866009/54001

[commit-bot: I haz the power, 2013-05-28 07:35:05]

Change committed as 151219