Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 14864023: [Android] Add app version code to chrome://version. (Closed)

Created:
7 years, 7 months ago by shashi
Modified:
7 years, 7 months ago
Reviewers:
Yaron, Evan Stade
CC:
chromium-reviews, erikwright+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Android] Add app version code to chrome://version. Version code information is useful for identifying different arch versions of Chrome on Android. BUG=233234 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M base/android/java/src/org/chromium/base/BuildInfo.java View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/about_version.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
shashi
chrome/browser: estade base/android: yfriedman
7 years, 7 months ago (2013-05-10 21:02:42 UTC) #1
Yaron
lgtm
7 years, 7 months ago (2013-05-10 22:48:29 UTC) #2
shashi
chrome/browser/ui: sky chrome/browser/resources: estade
7 years, 7 months ago (2013-05-13 20:28:05 UTC) #3
sky
estade is an owner for webui (and understands it), so I'm removing myself as a ...
7 years, 7 months ago (2013-05-13 22:45:46 UTC) #4
shashi
estade: gentle reminder, hopefully you are back from I/O :).
7 years, 7 months ago (2013-05-20 18:56:04 UTC) #5
Evan Stade
lgtm
7 years, 7 months ago (2013-05-21 23:21:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/14864023/1
7 years, 7 months ago (2013-05-21 23:26:39 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-21 23:51:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shashishekhar@chromium.org/14864023/1
7 years, 7 months ago (2013-05-22 00:39:14 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-22 06:24:26 UTC) #10
Message was sent while issue was closed.
Change committed as 201446

Powered by Google App Engine
This is Rietveld 408576698