Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14864005: Make cloud print dialog work with cloud printer on first signin. (Closed)

Created:
7 years, 7 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 7 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Make cloud print dialog work with cloud printer on first signin. Better check for current URL. Assign data only to cloud print URLs. Don't reset data_. BUG=236786 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199109

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -23 lines) Patch
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 6 chunks +19 lines, -23 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 7 months ago (2013-05-07 08:44:37 UTC) #1
gene
On 2013/05/07 08:44:37, Vitaly Buka wrote: lgtm
7 years, 7 months ago (2013-05-07 08:57:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/2001
7 years, 7 months ago (2013-05-07 16:31:07 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=124987
7 years, 7 months ago (2013-05-07 16:55:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/33002
7 years, 7 months ago (2013-05-07 17:35:02 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125038
7 years, 7 months ago (2013-05-07 17:52:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/33004
7 years, 7 months ago (2013-05-07 18:12:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/47002
7 years, 7 months ago (2013-05-07 18:35:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/38004
7 years, 7 months ago (2013-05-07 19:03:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/35004
7 years, 7 months ago (2013-05-07 19:20:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/42004
7 years, 7 months ago (2013-05-07 19:27:43 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125197
7 years, 7 months ago (2013-05-07 20:06:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/42004
7 years, 7 months ago (2013-05-07 20:25:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14864005/61003
7 years, 7 months ago (2013-05-08 17:46:15 UTC) #14
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 04:49:59 UTC) #15
Message was sent while issue was closed. 
Change committed as 199109

Powered by Google App Engine
This is Rietveld 408576698