Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 14860017: Bring back Leandro's GL state restore (Closed)

Created:
7 years, 7 months ago by boliu
Modified:
7 years, 7 months ago
Reviewers:
joth, no sievers
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Bring back Leandro's GL state restore BUG=230195 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202348

Patch Set 1 #

Patch Set 2 : Also force restore using gl context #

Patch Set 3 : Remove restore hack again #

Total comments: 2

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -5 lines) Patch
M android_webview/browser/in_process_renderer/in_process_view_renderer.cc View 1 2 3 4 chunks +149 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
boliu
Let's land this. Daniel, could you skim this. Should be a direct copy from Leandro's ...
7 years, 7 months ago (2013-05-25 22:42:34 UTC) #1
joth
lgtm https://codereview.chromium.org/14860017/diff/4001/android_webview/browser/in_process_renderer/in_process_view_renderer.cc File android_webview/browser/in_process_renderer/in_process_view_renderer.cc (right): https://codereview.chromium.org/14860017/diff/4001/android_webview/browser/in_process_renderer/in_process_view_renderer.cc#newcode88 android_webview/browser/in_process_renderer/in_process_view_renderer.cc:88: } we could DCHECK vertex_array_buffer_binding_ == 0 and ...
7 years, 7 months ago (2013-05-25 23:04:16 UTC) #2
boliu
all done
7 years, 7 months ago (2013-05-26 04:05:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/14860017/10001
7 years, 7 months ago (2013-05-26 06:04:08 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-26 06:04:16 UTC) #5
Message was sent while issue was closed.
Change committed as 202348

Powered by Google App Engine
This is Rietveld 408576698