Support Android in MallocHook for mmap, munmap and mremap.

Support Android in MallocHook for mmap, munmap and mremap.

sbrk is not supported for now because __sbrk is not provided by Bionic.
Chrome for Android doesn't look like using sbrk.

BUG=162208
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199899

[Dai Mikurube (NOT FULLTIME), 2013-05-07 10:37:01]

Could you take a look (when you have time)?

It's considered to be upstreamed to gperftools.

[willchan no longer on Chromium, 2013-05-09 21:07:44]

I'm going to wait for digit to review this first.

[Dai Mikurube (NOT FULLTIME), 2013-05-10 09:20:50]

digit may show up in the next week (and, it's no problem).

[Dai Mikurube (NOT FULLTIME), 2013-05-13 15:54:52]

gentle ping (not much in a hurry, but just a reminder)

what do you think, digit?

[digit1, 2013-05-13 16:14:42]

Sorry for the delay, I was on vacation last week. lgtm :)

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
File third_party/tcmalloc/chromium/src/base/linux_syscall_support.h (right):

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
third_party/tcmalloc/chromium/src/base/linux_syscall_support.h:158: #if
defined(__ANDROID__) || defined(ANDROID)
__ANDROID__ should be defined by the toolchain automatically, so I think
checking for it should be enough in all cases :)

(and if not, the gyp files should be changed to add __ANDROID__ when using a
broken compiler that doesn't).

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
third_party/tcmalloc/chromium/src/base/linux_syscall_support.h:479: // ulong is
not defined in Android while used to define __llseek.
How, do you have more information about this? I'm thinking of filing an NDK bug
for this.

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
File third_party/tcmalloc/chromium/src/malloc_hook_mmap_linux.h (right):

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
third_party/tcmalloc/chromium/src/malloc_hook_mmap_linux.h:232: // Don't hook
sbrk in Androis since Android doesn't have __sbrk.
Small typo here. Also probably better avoid the repetition, i.e.:

  // Don't hook sbrk() in Android, since it doesn't expose __sbrk.

[Dai Mikurube (NOT FULLTIME), 2013-05-13 16:36:06]

Thanks.  Just adding a comment about ulong.  (not fixed for other comments yet)

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
File third_party/tcmalloc/chromium/src/base/linux_syscall_support.h (right):

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
third_party/tcmalloc/chromium/src/base/linux_syscall_support.h:479: // ulong is
not defined in Android while used to define __llseek.
On 2013/05/13 16:14:42, digit1 wrote:
> How, do you have more information about this? I'm thinking of filing an NDK
bug
> for this.

I'm not confident.  What I know is:
* uint is defined in /android-14/arch-arm/usr/include/sys/types.h
* ulong is not there
* in normal Linux, both are defined in /usr/include/sys/types.h

If it is fixed in future, I'm adding a TODO to remove it in future.

[willchan no longer on Chromium, 2013-05-13 20:26:40]

lgtm

[Dai Mikurube (NOT FULLTIME), 2013-05-13 21:25:52]

Thanks, digit and willchan.  Fixed them, and committing...

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
File third_party/tcmalloc/chromium/src/base/linux_syscall_support.h (right):

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
third_party/tcmalloc/chromium/src/base/linux_syscall_support.h:158: #if
defined(__ANDROID__) || defined(ANDROID)
On 2013/05/13 16:14:42, digit1 wrote:
> __ANDROID__ should be defined by the toolchain automatically, so I think
> checking for it should be enough in all cases :)
> 
> (and if not, the gyp files should be changed to add __ANDROID__ when using a
> broken compiler that doesn't).

Got it.  Removed defined(ANDROID) from this patch.

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
File third_party/tcmalloc/chromium/src/malloc_hook_mmap_linux.h (right):

https://codereview.chromium.org/14859005/diff/4001/third_party/tcmalloc/chrom...
third_party/tcmalloc/chromium/src/malloc_hook_mmap_linux.h:232: // Don't hook
sbrk in Androis since Android doesn't have __sbrk.
On 2013/05/13 16:14:42, digit1 wrote:
> Small typo here. Also probably better avoid the repetition, i.e.:
> 
>   // Don't hook sbrk() in Android, since it doesn't expose __sbrk.

Thanks.  Replaced the comment.

[commit-bot: I haz the power, 2013-05-13 21:26:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14859005/19001

[commit-bot: I haz the power, 2013-05-13 22:23:51]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-05-13 22:53:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14859005/19001

[commit-bot: I haz the power, 2013-05-14 04:48:33]

Change committed as 199899