Issue 14858037: Move [Get|Set]WebStoreLogin methods from ExtensionPrefs to WebstorePrivateAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14858037: Move [Get|Set]WebStoreLogin methods from ExtensionPrefs to WebstorePrivateAPI (Closed)

Created:
7 years, 7 months ago by Devlin

Modified:
7 years, 7 months ago

Reviewers:
Yoyo Zhou, Devlin

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move [Get|Set]WebStoreLogin methods from ExtensionPrefs to WebstorePrivateAPI BUG=180083 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201983

Patch Set 3 : Latest master for CQ #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -43 lines)			Patch
M	chrome/browser/extensions/api/webstore_private/webstore_private_api.cc	View	1	4 chunks	+23 lines, -15 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.h	View	1 2	1 chunk	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_prefs.cc	View	1 2	3 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

LGTM https://chromiumcodereview.appspot.com/14858037/diff/1/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc File chrome/browser/extensions/api/webstore_private/webstore_private_api.cc (right): https://chromiumcodereview.appspot.com/14858037/diff/1/chrome/browser/extensions/api/webstore_private/webstore_private_api.cc#newcode146 chrome/browser/extensions/api/webstore_private/webstore_private_api.cc:146: } nit: newline after

7 years, 7 months ago (2013-05-15 18:36:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/14858037/16001

7 years, 7 months ago (2013-05-24 02:07:05 UTC) #3

Message was sent while issue was closed.

Change committed as 201983

Expand Messages | Collapse Messages

Issue 14858037: Move [Get|Set]WebStoreLogin methods from ExtensionPrefs to WebstorePrivateAPI (Closed)

Description

Patch Set 1 #

Patch Set 2 : Nitfix #

Patch Set 3 : Latest master for CQ #

Messages