Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 14858018: [android] Fix the adb_gdb script. (Closed)

Created:
7 years, 7 months ago by mkosiba (inactive)
Modified:
7 years, 7 months ago
Reviewers:
eseidel, Yaron, nilesh, digit1
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, choose the other janx, eseidel, abarth-chromium
Visibility:
Public.

Description

[android] Fix the adb_gdb script. The ndk under third_party was updated to not contain the 32-bit toolchains but the script continues to reference those. BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/adb_gdb View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mkosiba (inactive)
@nilesh - dropping the 32 bit toolchains was intentional, right?
7 years, 7 months ago (2013-05-09 13:26:00 UTC) #1
Yaron
lgtm Yes, thanks. This probably explains your issues yesterday, Eric
7 years, 7 months ago (2013-05-09 17:23:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/14858018/1
7 years, 7 months ago (2013-05-09 17:25:02 UTC) #3
commit-bot: I haz the power
Change committed as 199234
7 years, 7 months ago (2013-05-09 17:25:16 UTC) #4
eseidel
7 years, 7 months ago (2013-05-09 19:01:32 UTC) #5
Message was sent while issue was closed.
Yes, thank you!

Powered by Google App Engine
This is Rietveld 408576698