Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: chrome/browser/chromeos/drive/resource_metadata.cc

Issue 14858016: drive: Stop using callback for ResourceMetadataStorage::Iterate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename methods Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/drive/resource_metadata.cc
diff --git a/chrome/browser/chromeos/drive/resource_metadata.cc b/chrome/browser/chromeos/drive/resource_metadata.cc
index 7da356d2d87a62b56bc5d3887b788b3f056d079a..d1e9463fd66e927652a2e2042e8ac59dc0e18171 100644
--- a/chrome/browser/chromeos/drive/resource_metadata.cc
+++ b/chrome/browser/chromeos/drive/resource_metadata.cc
@@ -827,7 +827,10 @@ void ResourceMetadata::IterateEntries(const IterateCallback& callback) {
DCHECK(blocking_task_runner_->RunsTasksOnCurrentThread());
DCHECK(!callback.is_null());
- storage_->Iterate(callback);
+ scoped_ptr<ResourceMetadataStorage::Iterator> it = storage_->GetIterator();
+ for (; !it->IsAtEnd(); it->Advance())
+ callback.Run(it->Get());
+ DCHECK(!it->HasError()); // TODO(hashimoto): Report error correctly.
}
void ResourceMetadata::GetEntryInfoPairByPathsOnUIThreadAfterGetFirst(
« no previous file with comments | « chrome/browser/chromeos/drive/resource_metadata.h ('k') | chrome/browser/chromeos/drive/resource_metadata_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698