Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 14858016: drive: Stop using callback for ResourceMetadataStorage::Iterate (Closed)

Created:
7 years, 7 months ago by hashimoto
Modified:
7 years, 7 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Stop using callback for ResourceMetadataStorage::Iterate BUG=238999 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199400

Patch Set 1 : #

Total comments: 2

Patch Set 2 : rename methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -37 lines) Patch
M chrome/browser/chromeos/drive/resource_metadata.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.h View 1 4 chunks +28 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage.cc View 1 3 chunks +41 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 1 4 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hashimoto
7 years, 7 months ago (2013-05-09 11:16:50 UTC) #1
hidehiko
https://codereview.chromium.org/14858016/diff/2001/chrome/browser/chromeos/drive/resource_metadata_storage.h File chrome/browser/chromeos/drive/resource_metadata_storage.h (right): https://codereview.chromium.org/14858016/diff/2001/chrome/browser/chromeos/drive/resource_metadata_storage.h#newcode46 chrome/browser/chromeos/drive/resource_metadata_storage.h:46: void MoveForward(); How about name the methods Next()/Done() or ...
7 years, 7 months ago (2013-05-09 11:31:23 UTC) #2
hashimoto
https://codereview.chromium.org/14858016/diff/2001/chrome/browser/chromeos/drive/resource_metadata_storage.h File chrome/browser/chromeos/drive/resource_metadata_storage.h (right): https://codereview.chromium.org/14858016/diff/2001/chrome/browser/chromeos/drive/resource_metadata_storage.h#newcode46 chrome/browser/chromeos/drive/resource_metadata_storage.h:46: void MoveForward(); On 2013/05/09 11:31:24, hidehiko wrote: > How ...
7 years, 7 months ago (2013-05-09 11:48:46 UTC) #3
hidehiko
lgtm
7 years, 7 months ago (2013-05-09 11:54:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14858016/5001
7 years, 7 months ago (2013-05-10 02:27:36 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 06:09:00 UTC) #6
Message was sent while issue was closed.
Change committed as 199400

Powered by Google App Engine
This is Rietveld 408576698