tests/submit-from-new-dir.sh - Issue 14854003: Make git-cl more accurately imitate git's editor selection process, and respect $VISUAL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/submit-from-new-dir.sh

Issue 14854003: Make git-cl more accurately imitate git's editor selection process, and respect $VISUAL. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Make tests use $GIT_EDITOR instead of $EDITOR (previously they failed for me, as $EDITOR was overri… Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/submit-from-new-dir.sh

diff --git a/tests/submit-from-new-dir.sh b/tests/submit-from-new-dir.sh

index c1dd89b4cedf254e38159ab2751b0e7bf96a3677..fe2546510e50fd1531a457bfe28668005253d723 100755

--- a/tests/submit-from-new-dir.sh

+++ b/tests/submit-from-new-dir.sh

@@ -26,7 +26,7 @@ setup_gitsvn

cd dir

echo "some work done on a branch" >> test

git add test; git commit -q -m "branch work"

- export EDITOR=$(which true)

+ export GIT_EDITOR=$(which true)

test_expect_success "upload succeeds" \

"$GIT_CL upload -m test master | grep -q 'Issue created'"

test_expect_success "git-cl dcommits ok" \

« no previous file with comments | « tests/save-description-on-failure.sh ('k') | tests/upload-local-tracking-branch.sh » ('j') | no next file with comments »