Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: tests/basic.sh

Issue 14854003: Make git-cl more accurately imitate git's editor selection process, and respect $VISUAL. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Make tests use $GIT_EDITOR instead of $EDITOR (previously they failed for me, as $EDITOR was overriā€¦ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/abandon.sh ('k') | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/basic.sh
diff --git a/tests/basic.sh b/tests/basic.sh
index e22e2151d9c331b56cb09a6a4f51f6b9c0c589dc..430ce29c4c5ad40fac4eaa9942c95039b3f918b0 100755
--- a/tests/basic.sh
+++ b/tests/basic.sh
@@ -29,7 +29,7 @@ setup_gitsvn
"$GIT_CL status | grep -q 'no issue'"
# Prevent the editor from coming up when you upload.
- export EDITOR=$(which true)
+ export GIT_EDITOR=$(which true)
test_expect_success "upload succeeds (needs a server running on localhost)" \
"$GIT_CL upload -m test master | grep -q 'Issue created'"
« no previous file with comments | « tests/abandon.sh ('k') | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698