Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tests/abandon.sh

Issue 14854003: Make git-cl more accurately imitate git's editor selection process, and respect $VISUAL. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Make tests use $GIT_EDITOR instead of $EDITOR (previously they failed for me, as $EDITOR was overriā€¦ Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | tests/basic.sh » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/abandon.sh
diff --git a/tests/abandon.sh b/tests/abandon.sh
index c4bba75e1ff1b11353a75c20c4e5ab06ee12420c..e59d309e324c06c9f1e6ef5d1e7091c21f64563d 100755
--- a/tests/abandon.sh
+++ b/tests/abandon.sh
@@ -22,7 +22,7 @@ setup_gitsvn
git checkout -q -b abandoned
echo "some work done on a branch" >> test
git add test; git commit -q -m "branch work"
- export EDITOR=$(which true)
+ export GIT_EDITOR=$(which true)
test_expect_success "upload succeeds" \
"$GIT_CL upload -m test master | grep -q 'Issue created'"
« no previous file with comments | « git_cl.py ('k') | tests/basic.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698