Issue 14853005: Move static functions in WebSocketJobTest into namespace net

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14853005: Move static functions in WebSocketJobTest into namespace net (Closed)

Created:
7 years, 7 months ago by Deprecated (see juliatuttle)

Modified:
7 years, 7 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Move static functions in WebSocketJobTest into namespace net Instead of using net:: dozens of times, just move the static bits before the test into the net namespace as well. BUG=226192 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199001

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+130 lines, -130 lines)			Patch
	M	net/websockets/websocket_job_spdy2_unittest.cc	View		14 chunks	+65 lines, -65 lines	0 comments	Download
	M	net/websockets/websocket_job_spdy3_unittest.cc	View		14 chunks	+65 lines, -65 lines	0 comments	Download

Total messages: 6 (0 generated)

Deprecated (see juliatuttle)

PTAL, rch. As promised, this moves the fiddly bits above WebSocketJobTest into the net namespace ...

7 years, 7 months ago (2013-05-07 22:14:55 UTC) #1

Deprecated (see juliatuttle)

PTAL, rch. As promised, this moves the fiddly bits above WebSocketJobTest into the net namespace ...

7 years, 7 months ago (2013-05-07 22:15:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/14853005/1

7 years, 7 months ago (2013-05-07 22:27:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ttuttle@chromium.org/14853005/1

7 years, 7 months ago (2013-05-08 19:13:51 UTC) #5

Message was sent while issue was closed.

Change committed as 199001