Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Issue 14850014: Fix subscripting support. (Closed)

Created:
7 years, 7 months ago by qsr
Modified:
7 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Visibility:
Public.

Description

Fix subscripting support. Subscripting needs libarc_lite to works. To force compilation with this library, the linker must have the -f-obj-arc parameter. R=stuartmorgan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
qsr
7 years, 7 months ago (2013-05-06 09:39:59 UTC) #1
stuartmorgan
LGTM
7 years, 7 months ago (2013-05-06 09:49:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/14850014/1
7 years, 7 months ago (2013-05-06 09:54:03 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 12:25:12 UTC) #4
Message was sent while issue was closed.
Change committed as 198428

Powered by Google App Engine
This is Rietveld 408576698