Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: net/websockets/websocket_errors_unittest.cc

Issue 14850012: Add missing status codes to WebSocketError enum. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove other mux status codes. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/websockets/websocket_errors.cc ('k') | net/websockets/websocket_frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/websockets/websocket_errors_unittest.cc
diff --git a/net/websockets/websocket_errors_unittest.cc b/net/websockets/websocket_errors_unittest.cc
index f0e719d8d9809f32b41d81dc11ef13f413a4b6d5..1a4fca614537e8bdb28dbf79d08141710f3a529a 100644
--- a/net/websockets/websocket_errors_unittest.cc
+++ b/net/websockets/websocket_errors_unittest.cc
@@ -4,17 +4,25 @@
#include "net/websockets/websocket_errors.h"
+#include "net/base/net_errors.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net {
namespace {
+// Confirm that the principle classes of errors are converted correctly. We
+// don't exhaustively test every error code, as it would be long, repetitive,
+// and add little value.
TEST(WebSocketErrorToNetErrorTest, ResultsAreCorrect) {
- EXPECT_EQ(OK, WebSocketErrorToNetError(WEB_SOCKET_OK));
+ EXPECT_EQ(OK, WebSocketErrorToNetError(kWebSocketNormalClosure));
EXPECT_EQ(ERR_WS_PROTOCOL_ERROR,
- WebSocketErrorToNetError(WEB_SOCKET_ERR_PROTOCOL_ERROR));
+ WebSocketErrorToNetError(kWebSocketErrorProtocolError));
EXPECT_EQ(ERR_MSG_TOO_BIG,
- WebSocketErrorToNetError(WEB_SOCKET_ERR_MESSAGE_TOO_BIG));
+ WebSocketErrorToNetError(kWebSocketErrorMessageTooBig));
+ EXPECT_EQ(ERR_CONNECTION_CLOSED,
+ WebSocketErrorToNetError(kWebSocketErrorNoStatusReceived));
+ EXPECT_EQ(ERR_SSL_PROTOCOL_ERROR,
+ WebSocketErrorToNetError(kWebSocketErrorTlsHandshake));
}
} // namespace
« no previous file with comments | « net/websockets/websocket_errors.cc ('k') | net/websockets/websocket_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698