Re-implement form validation message UI with native widgets (GTK)

Re-implement form validation message UI with native widgets (GTK)

This CL adds a GTK implementation of ValidationMessageBubble, and
enable ValidationMessageAgent for GTK platform.

BUG=90252, 90958, 92816, 104829, 106621, 113352, 115451, 125330, 143356, 155448, 166981, 231170, 235717
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198199

[tkent, 2013-05-02 12:17:41]

FYI:
https://chromiumcodereview.appspot.com/13160004/ (common part and Cocoa)
https://chromiumcodereview.appspot.com/14627004/ (Views)

I tried to add unit test like them. But I couldn't find a simple way to get
dimension of a GtkWidget.

[Nico, 2013-05-02 16:55:59]

I'll leave this to estade, he knows gtk 4560000 times better than I do. Maybe he
knows how to write a test, too.

The minor amount of non-gtk code in this CL lgtm.

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
File chrome/browser/ui/gtk/validation_message_bubble_gtk.cc (right):

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:42: static GtkWidget*
constructContent(const string16& main_text,
nit: chromium style is to capitalize the first letter

[Evan Stade, 2013-05-02 22:34:46]

dimension of a GtkWidget... gtk_widget_get_allocation?

[Evan Stade, 2013-05-02 22:42:33]

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
File chrome/browser/ui/gtk/validation_message_bubble_gtk.cc (right):

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:86:
gtk_misc_set_padding(GTK_MISC(icon), 2, 2);
what's this magic 2 for? why not add the padding in box_pack_start and set the
vertical alignment to 0.5?

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:93:
gtk_box_pack_start(GTK_BOX(icon_text_box), icon, FALSE, FALSE, 0);
I think this is equivalent to gtk_container_add

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:113:
gtk_box_pack_start(GTK_BOX(icon_text_box), text_box, FALSE, TRUE, 0);
I think this is equivalent to gtk_container_add (note that the TRUE has no
effect because of the previous FALSE)

[tkent, 2013-05-03 14:53:03]

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
File chrome/browser/ui/gtk/validation_message_bubble_gtk.cc (right):

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:42: static GtkWidget*
constructContent(const string16& main_text,
On 2013/05/02 16:55:59, Nico wrote:
> nit: chromium style is to capitalize the first letter 

Done.

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:86:
gtk_misc_set_padding(GTK_MISC(icon), 2, 2);
On 2013/05/02 22:42:33, Evan Stade wrote:
> what's this magic 2 for? why not add the padding in box_pack_start and set the
> vertical alignment to 0.5?

I changed 2 to kPadding.
I don't want to center icon vertically. It should be put on the top of
icon_text_box with some padding.

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:93:
gtk_box_pack_start(GTK_BOX(icon_text_box), icon, FALSE, FALSE, 0);
On 2013/05/02 22:42:33, Evan Stade wrote:
> I think this is equivalent to gtk_container_add

Done.

https://codereview.chromium.org/14848002/diff/2001/chrome/browser/ui/gtk/vali...
chrome/browser/ui/gtk/validation_message_bubble_gtk.cc:113:
gtk_box_pack_start(GTK_BOX(icon_text_box), text_box, FALSE, TRUE, 0);
On 2013/05/02 22:42:33, Evan Stade wrote:
> I think this is equivalent to gtk_container_add (note that the TRUE has no
> effect because of the previous FALSE)

Done.

[tkent, 2013-05-03 14:53:33]

I uploaded a new patch.  Would you take another look please?

[Evan Stade, 2013-05-03 17:38:55]

lgtm

[commit-bot: I haz the power, 2013-05-03 18:08:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/14848002/12001

[commit-bot: I haz the power, 2013-05-03 18:49:18]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-03 21:24:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tkent@chromium.org/14848002/12001

[commit-bot: I haz the power, 2013-05-03 21:46:18]

Change committed as 198199