Issue 14847008: Update deprecated maps before generating optimized code.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -27 lines)			Patch
M	src/ast.h	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 2 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.cc	View	1 2	1 chunk	+8 lines, -13 lines	0 comments	Download
M	src/type-info.cc	View	1 2	4 chunks	+3 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

danno

https://codereview.chromium.org/14847008/diff/8001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/14847008/diff/8001/src/objects.h#newcode5347 src/objects.h:5347: static inline Handle<Map> Update(Handle<Map> map); Not sure I like ...

7 years, 7 months ago (2013-05-02 14:29:30 UTC) #2

Toon Verwaest

Addressed comments https://chromiumcodereview.appspot.com/14847008/diff/8001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/14847008/diff/8001/src/objects.h#newcode5347 src/objects.h:5347: static inline Handle<Map> Update(Handle<Map> map); On 2013/05/02 ...

7 years, 7 months ago (2013-05-02 15:22:40 UTC) #3

danno

lgtm with comments https://codereview.chromium.org/14847008/diff/9007/src/objects.h File src/objects.h (right): https://codereview.chromium.org/14847008/diff/9007/src/objects.h#newcode5347 src/objects.h:5347: static inline Handle<Map> CurrentMapForDeprecated(Handle<Map> map); Comment ...

7 years, 7 months ago (2013-05-02 15:27:18 UTC) #4

Toon Verwaest

7 years, 7 months ago (2013-05-02 15:40:17 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r14522 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14847008: Update deprecated maps before generating optimized code. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Calculate slack based on the correct descriptor array #

Patch Set 3 : Addressed comments #

Patch Set 4 : Addressed comment #

Messages