third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc - Issue 148463003: libaddressinput - reduce number of copies in storage class by 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc

Issue 148463003: libaddressinput - reduce number of copies in storage class by 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc

diff --git a/third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc b/third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc

index aac52e14f2962a46345384c78d9f870530495e59..ff9895ee76de7bc6247ac724af12471ec1a6d2f4 100644

--- a/third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc

+++ b/third_party/libaddressinput/chromium/cpp/test/storage_test_runner.cc

@@ -63,7 +63,7 @@ void StorageTestRunner::GetWithoutPutReturnsEmptyData() {

void StorageTestRunner::GetReturnsWhatWasPut() {

ClearValues();

- storage_->Put("key", "value");

+ storage_->Put("key", make_scoped_ptr(new std::string("value")));

storage_->Get("key", BuildCallback());

EXPECT_TRUE(success_);

@@ -73,8 +73,8 @@ void StorageTestRunner::GetReturnsWhatWasPut() {

void StorageTestRunner::SecondPutOverwritesData() {

ClearValues();

- storage_->Put("key", "bad-value");

- storage_->Put("key", "good-value");

+ storage_->Put("key", make_scoped_ptr(new std::string("bad-value")));

+ storage_->Put("key", make_scoped_ptr(new std::string("good-value")));

storage_->Get("key", BuildCallback());

EXPECT_TRUE(success_);

« no previous file with comments | « third_party/libaddressinput/chromium/cpp/test/retriever_test.cc ('k') | no next file » | no next file with comments »