Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 14846029: Pass caret bound to SchedulePaintInRect in local coordinate (Closed)

Created:
7 years, 7 months ago by Yohei Yukawa
Modified:
7 years, 7 months ago
Reviewers:
msw, sky
CC:
chromium-reviews, nona+watch_chromium.org, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Pass caret bound to SchedulePaintInRect in local coordinate so that the caret can be blinking correctly. This change should have been included in r197858. BUG=238136 TEST=Manually done on Windows 7. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Yohei Yukawa
7 years, 7 months ago (2013-05-07 23:33:39 UTC) #1
msw
LGTM; thanks for the quick fix! We might need to merge this to the M28 ...
7 years, 7 months ago (2013-05-07 23:38:47 UTC) #2
sky
LGTM
7 years, 7 months ago (2013-05-08 15:42:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/14846029/1
7 years, 7 months ago (2013-05-08 18:24:41 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 04:49:07 UTC) #5
Message was sent while issue was closed.
Change committed as 199107

Powered by Google App Engine
This is Rietveld 408576698