Update IOSurface scale factor before compare

Update device scale factor for the IOSurface before checking if there
is a match. When initially created, the IOSurface is unaware of its
scale factor, which can result in compatible IOSurfaces not being used

BUG=237293
NOTRY=true
TEST=follow instructions on http://crbug.com237293, on a retina Mac

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198785

[ccameron, 2013-05-07 18:45:18]

Ptal.

I have a more involved fix in the works which make the CompositingIOSurface not
track the density independent scale at all (but rather always computes it), but
that won't be ready to merge into M28 for the upcoming cut.

[Ken Russell (switch to Gerrit), 2013-05-07 19:23:51]

LGTM as far as I can see from code inspection, but in code like this, manual
testing is the only thing that can verify the change.

Please update the CL to add a TEST= line describing how to test this, and make
sure it's included in whatever CL is eventually filed for the M28 merge.

https://codereview.chromium.org/14846015/diff/4001/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/14846015/diff/4001/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_view_mac.mm:1337:
compositing_iosurface_->SetDeviceScaleFactor(ScaleFactor(cocoa_view_));
It seems odd that this is done as a side-effect of calling
HasAcceleratedSurface. Is there a more obvious place this could be done?

[ccameron, 2013-05-07 19:27:36]

Thanks!!

https://codereview.chromium.org/14846015/diff/4001/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/14846015/diff/4001/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_view_mac.mm:1337:
compositing_iosurface_->SetDeviceScaleFactor(ScaleFactor(cocoa_view_));
On 2013/05/07 19:23:51, kbr wrote:
> It seems odd that this is done as a side-effect of calling
> HasAcceleratedSurface. Is there a more obvious place this could be done?

Yes, this I was unhappy with this too. The other place this happens is in Draw
(which also doesn't make too much sense to have side effects on resolution).

The version that I'm working on for trunk has no side effects here (but has lots
more diffs).

[commit-bot: I haz the power, 2013-05-07 19:27:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/14846015/4001

[commit-bot: I haz the power, 2013-05-07 19:49:59]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-05-07 20:05:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ccameron@chromium.org/14846015/4001

[commit-bot: I haz the power, 2013-05-07 20:05:23]

Change committed as 198785