Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14845009: dbus: Use fakes for some clients and utils for MockDBusThreadManagerWithoutGMock (Closed)

Created:
7 years, 7 months ago by Haruki Sato
Modified:
7 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

dbus: Use fakes for some clients and utils for MockDBusThreadManagerWithoutGMock This is a retrial. Fakes are used for - PowerManagerClient (with a PowerPolicyController instance) - SessionManagerClient - UpdateEngineClient BUG=234084 TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198757

Patch Set 1 #

Patch Set 2 : fix memner order. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M chromeos/chromeos.gyp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.h View 1 4 chunks +12 lines, -3 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc View 6 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Haruki Sato
7 years, 7 months ago (2013-05-06 23:27:27 UTC) #1
satorux1
LGTM
7 years, 7 months ago (2013-05-07 05:55:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/14845009/10001
7 years, 7 months ago (2013-05-07 05:57:54 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=144807
7 years, 7 months ago (2013-05-07 08:04:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/14845009/10001
7 years, 7 months ago (2013-05-07 08:06:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=144896
7 years, 7 months ago (2013-05-07 14:38:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/14845009/10001
7 years, 7 months ago (2013-05-07 14:58:40 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 17:34:51 UTC) #8
Message was sent while issue was closed. 
Change committed as 198757

Powered by Google App Engine
This is Rietveld 408576698