Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14844009: [Android] Only always trigger stripping with component build (Closed)

Created:
7 years, 7 months ago by cjhopman
Modified:
7 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Only always trigger stripping with component build With the component build we need to always trigger stripping because we can't specify the inputs correctly at gyp time. This is not required for the non-component build. Also, slightly refactor strip_native_libraries.gypi and its users to make it more clear what variables are being used by the .gypi. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200422

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unwanted line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M build/android/native_app_dependencies.gypi View 3 chunks +5 lines, -10 lines 0 comments Download
M build/android/strip_native_libraries.gypi View 1 4 chunks +12 lines, -8 lines 0 comments Download
M build/java_apk.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
7 years, 7 months ago (2013-05-14 22:25:45 UTC) #1
Yaron
https://codereview.chromium.org/14844009/diff/1/build/android/strip_native_libraries.gypi File build/android/strip_native_libraries.gypi (left): https://codereview.chromium.org/14844009/diff/1/build/android/strip_native_libraries.gypi#oldcode23 build/android/strip_native_libraries.gypi:23: 'action_name': 'strip_native_libraries', Why did you pull this out?
7 years, 7 months ago (2013-05-15 00:32:41 UTC) #2
cjhopman
https://codereview.chromium.org/14844009/diff/1/build/android/strip_native_libraries.gypi File build/android/strip_native_libraries.gypi (left): https://codereview.chromium.org/14844009/diff/1/build/android/strip_native_libraries.gypi#oldcode23 build/android/strip_native_libraries.gypi:23: 'action_name': 'strip_native_libraries', On 2013/05/15 00:32:41, Yaron wrote: > Why ...
7 years, 7 months ago (2013-05-15 21:13:33 UTC) #3
Yaron
lgtm
7 years, 7 months ago (2013-05-15 22:09:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14844009/8001
7 years, 7 months ago (2013-05-15 22:18:25 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 02:40:32 UTC) #6
Message was sent while issue was closed.
Change committed as 200422

Powered by Google App Engine
This is Rietveld 408576698