Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 14842006: Copy new-run-webkit-httpd to run-blink-httpd, delete run-webkit-httpd. (Closed)

Created:
7 years, 7 months ago by Nico
Modified:
7 years, 7 months ago
Reviewers:
Dirk Pranke, eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Copy new-run-webkit-httpd to run-blink-httpd, delete run-webkit-httpd. In a second step, I'll update the chromium side to call run-blink-httpd instead of new-run-webkit-httpd. Then I'll delete new-run-webkit-httpd. Do the same for run-webkit-websocketserver, but since nothing on the chromium side calls new-run-webkit-websocketserver delete the old file. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149631

Patch Set 1 #

Patch Set 2 : sockets2 #

Patch Set 3 : . #

Patch Set 4 : blink #

Patch Set 5 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -307 lines) Patch
D Tools/Scripts/new-run-webkit-websocketserver View 1 2 1 chunk +0 lines, -115 lines 0 comments Download
A + Tools/Scripts/run-blink-httpd View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
A + Tools/Scripts/run-blink-websocketserver View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
M Tools/Scripts/run-webkit-httpd View 1 2 3 1 chunk +0 lines, -97 lines 0 comments Download
M Tools/Scripts/run-webkit-websocketserver View 1 2 3 1 chunk +0 lines, -88 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
7 years, 7 months ago (2013-05-03 00:37:42 UTC) #1
Dirk Pranke
lgtm
7 years, 7 months ago (2013-05-03 01:17:05 UTC) #2
eseidel
I guess we could also rename webkit/blink while we're at it. But maybe that's better ...
7 years, 7 months ago (2013-05-03 02:34:39 UTC) #3
Nico
On 2013/05/03 02:34:39, Eric Seidel (Google) wrote: > I guess we could also rename webkit/blink ...
7 years, 7 months ago (2013-05-03 02:43:03 UTC) #4
Nico
Done.
7 years, 7 months ago (2013-05-03 02:46:26 UTC) #5
eseidel
I think we haven't quite figured out what our script style is going to be ...
7 years, 7 months ago (2013-05-03 02:47:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14842006/1002
7 years, 7 months ago (2013-05-03 02:47:26 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-03 03:07:51 UTC) #8
Message was sent while issue was closed.
Change committed as 149631

Powered by Google App Engine
This is Rietveld 408576698