Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 14840008: Android: Disable 'sincos' optimization to avoid 'osmesa' link errors. (Closed)

Created:
7 years, 7 months ago by digit1
Modified:
7 years, 4 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Android: Disable 'sincos' optimization to avoid 'osmesa' link errors. BUG=237460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/mesa/mesa.gyp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
digit1
7 years, 7 months ago (2013-05-02 11:01:22 UTC) #1
digit1
All right, this fails because the current NDK binaries (from r8b release) do not support ...
7 years, 7 months ago (2013-05-02 14:38:18 UTC) #2
nilesh
On 2013/05/02 14:38:18, digit1 wrote: > All right, this fails because the current NDK binaries ...
7 years, 7 months ago (2013-05-02 15:18:08 UTC) #3
Ken Russell (switch to Gerrit)
LGTM -- but please note that an external contributor is in the process of upgrading ...
7 years, 7 months ago (2013-05-02 17:38:00 UTC) #4
nilesh
I will be landing this with the DEPS change.
7 years, 7 months ago (2013-05-02 18:59:20 UTC) #5
Ken Russell (switch to Gerrit)
7 years, 4 months ago (2013-07-31 01:58:14 UTC) #6
I'm closing this to get it off my review queue, since it's already landed.

Powered by Google App Engine
This is Rietveld 408576698